Update Breeze Look and Feel theme previews
ClosedPublic

Authored by GB_2 on Feb 2 2019, 6:05 PM.

Details

Summary

Update and improve some old Breeze Look and Feel theme previews (the Breeze Dark previews will be updated in a different revision, because they are in a different repo).

Test Plan

Open the Look and Feel KCM and the Splash Screen KCM.

Diff Detail

Repository
R120 Plasma Workspace
Branch
update-breeze-lookandfeel-theme-previews (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7806
Build 7824: arc lint + arc unit
GB_2 created this revision.Feb 2 2019, 6:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 2 2019, 6:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 2 2019, 6:05 PM
GB_2 edited the summary of this revision. (Show Details)Feb 2 2019, 6:05 PM
ngraham accepted this revision.Feb 2 2019, 7:50 PM
ngraham added a subscriber: ngraham.

Excellent.

This revision is now accepted and ready to land.Feb 2 2019, 7:50 PM

This and D18682 should probably go to the Plasma/5.15 branch and then merge to master.

If rebasing was too annoying last time, it's also acceptable to cherry-pick the commit onto the 5.15 branch, push, and then merge Plasma/5.15 into master. Let me know if anything's unclear.

abetts added a subscriber: abetts.Feb 2 2019, 8:18 PM

Maybe I am asking for a lot... but could these be animated and show what the splash screen does? Maybe a gif animation on hover?

GB_2 added a comment.Feb 2 2019, 8:27 PM

Maybe I am asking for a lot... but could these be animated and show what the splash screen does? Maybe a gif animation on hover?

There's already the preview button that shows the splash when you click on it.

GB_2 updated this revision to Diff 50761.Feb 3 2019, 10:29 AM

Improve Look and Feel theme previews

GB_2 edited the summary of this revision. (Show Details)Feb 3 2019, 12:45 PM
This revision was automatically updated to reflect the committed changes.