Saving Mirror Tool state to KRA
ClosedPublic

Authored by amedonosova on Jan 14 2019, 9:54 PM.

Details

Summary

Saving Mirror Tool state to KRA file, wished for in bug 339515.

BUG:339515

Test Plan
  • Set up mirror lines. Save, close and reopen. Expected result: the mirror lines and options should be automatically set and activated.
  • Open multiple files, with and without mirror lines. Expected result: Every open document should have separate configuration. Toolbar actions should affect only the currently active view.

Diff Detail

Repository
R37 Krita
Branch
amedonosova/mirrortool-saving
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7769
Build 7787: arc lint + arc unit
amedonosova created this revision.Jan 14 2019, 9:54 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptJan 14 2019, 9:54 PM
Restricted Application added a project: Krita. · View Herald Transcript
amedonosova requested review of this revision.Jan 14 2019, 9:54 PM
rempt added a subscriber: rempt.Jan 15 2019, 8:57 AM

Yes, I think you're on the right track. Don't forget to add apidox for new classes along the way :-)

amedonosova edited the summary of this revision. (Show Details)Feb 2 2019, 7:04 AM
amedonosova updated this revision to Diff 50696.Feb 2 2019, 7:05 AM
  • Do not save mirror axis config if default
  • code cleanup
  • Mirror axis: apply actions to current view; set action state on load

There is one issue left to be solved: the highlight on the paintop box buttons. When the first document is open, the buttons are checked, but not highlighted. After switching around documents it starts working.

rempt added a comment.Feb 6 2019, 10:37 AM

There is one issue left to be solved: the highlight on the paintop box buttons. When the first document is open, the buttons are checked, but not highlighted. After switching around documents it starts working.

Hm, that's curious. Maybe you could do something with KisDocument::sigLoadingFinished to initialize the buttons?

  • mirror axis: fix paintop box button highlighting
amedonosova retitled this revision from [WIP] Saving Mirror Tool state to KRA to Saving Mirror Tool state to KRA.Feb 13 2019, 7:14 AM
amedonosova edited the test plan for this revision. (Show Details)Feb 20 2019, 1:48 PM
rempt accepted this revision.Feb 21 2019, 11:54 AM
This revision is now accepted and ready to land.Feb 21 2019, 11:54 AM
This revision was automatically updated to reflect the committed changes.