[versioncontrolobserver] Update working directory on tab activation
ClosedPublic

Authored by anthonyfieroni on Jan 29 2019, 6:41 PM.

Details

Summary

That's second patch follows D17640 it tries to use new syntax connect by identify its parent as dolphin view and connect to activate signal. Another approach is to make new public slot and connect in dolphin view constructor.

https://phabricator.kde.org/D17640?id=48767#inline-103050

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
anthonyfieroni created this revision.Jan 29 2019, 6:41 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptJan 29 2019, 6:41 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Jan 29 2019, 6:41 PM

VersionControlObserver is exported class changing its constructor type parameter can brake ABI, but does it user of ? In other hand addition of public slot is ABI comfortable, so another approach can be better solution.

Let's make public slot approach.

I prefer your previous approach: an "observer" class is not supposed to have public slots, it should react on its own when stuff happens.

To avoid changing the constructor, we could add a new method setView(), similar to setModel() which we already have.

elvisangelaccio accepted this revision.Feb 2 2019, 4:58 PM
This revision is now accepted and ready to land.Feb 2 2019, 4:58 PM
This revision was automatically updated to reflect the committed changes.