Differential D18414

Prevent the Extra Arguments ComboBox to Stretch Too Much
ClosedPublic
Actions

Authored by narvaez on Jan 20 2019, 7:22 PM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Commits
R32:f7571e8b0589: Prevent the Extra Arguments ComboBox to Stretch Too Much
Summary

This basically ports d56117d68f2 to the build dir chooser.

Test Plan

Create a new project from template (pick any template, any valid name) and add some ridiculously long cmake extra arguments (say, -DTEST=<really long string>), then create a new project again and look at the size of the Extra Arguments combo box.

Diff Detail

Repository
R32 KDevelop
Branch
cmake-extra-arguments
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7351
Build 7369: arc lint + arc unit
narvaez created this revision.Jan 20 2019, 7:22 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 20 2019, 7:22 PM
narvaez requested review of this revision.Jan 20 2019, 7:22 PM
mwolff accepted this revision.Jan 25 2019, 2:25 PM
mwolff added a subscriber: mwolff.

lgtm, thanks

This revision is now accepted and ready to land.Jan 25 2019, 2:25 PM
narvaez closed this revision.Jan 26 2019, 5:54 PM

Revision Contents
Changeset List

Diff 49959

View Options

plugins/cmake/cmakebuilddirchooser.cpp

Loading...