Add plugin for taking photos on remote device
ClosedPublic

Authored by nicolasfella on Jan 9 2019, 10:29 PM.

Details

Summary

This plugin sends a request for a photo to the connected device. The device then sends the photo back, currently via the SharePlugin.

Test Plan

kdeconnect-cli --photo
Check for photo in Downlaods folder

Diff Detail

Repository
R224 KDE Connect
Branch
photo
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7303
Build 7321: arc lint + arc unit
nicolasfella created this revision.Jan 9 2019, 10:29 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJan 9 2019, 10:29 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Jan 9 2019, 10:29 PM
  • Add fileName parameter to request
apol added a comment.Jan 14 2019, 1:20 PM

Can you elaborate a bit on the use-case?

  • Expose signal to dbus
In D18140#392884, @apol wrote:

Can you elaborate a bit on the use-case?

I also find the use case a bit obscure.

Unless you are a spy and want to take photos from your phone without anyone noticing, I see no use of this plugin.

There are plenty of use cases. Using your phone as a scanner is a common one, for example.

macOS already has this feature and people think of plenty of uses for it on that platform.

In D18140#392884, @apol wrote:

Can you elaborate a bit on the use-case?

I also find the use case a bit obscure.

Unless you are a spy and want to take photos from your phone without anyone noticing, I see no use of this plugin.

I also fairly often want to take a photo to immediately send to my computer. The intermediate step of opening the photo in the gallery is not a big problem, but I think this plugin provides a good use

There are plenty of use cases. Using your phone as a scanner is a common one, for example.

macOS already has this feature and people think of plenty of uses for it on that platform.

You can already do that by taking a photo and sharing it via KDE Connect. This whole plugin just saves you one tap. Is this something we want?

You can already do that by taking a photo and sharing it via KDE Connect. This whole plugin just saves you one tap. Is this something we want?

My target use-case is not really about saving a tap but to allow other programs to trigger it (ideally abstracted by Purpose). For example an app that allows to set a profile picture could offer to take one via KDE Connect.

> macOS already has this feature and people think of plenty of uses for it on that platform.

Exactly, +1

albertvaka accepted this revision.Mar 4 2019, 10:37 PM

Let's merge this.

This revision is now accepted and ready to land.Mar 4 2019, 10:37 PM
albertvaka added inline comments.Mar 4 2019, 10:38 PM
cli/kdeconnect-cli.cpp
75

"Take a photo" is not what actually happens (and this confused me at the beginning). Maybe "open the camera and automatically transfer the photo taken" or something like that?

nicolasfella closed this revision.Mar 4 2019, 10:58 PM