Don't ignore default virtual devices
ClosedPublic

Authored by sharhalakis on Dec 24 2018, 8:25 PM.

Details

Summary

Ignoring virtual PA devices for volume control results in ignoring the
"Simultaneous output" devices. This makes it impossible to control them
with the volume keys, which is not what the user expects. As a workaround,
prefer not to ignore virtual devices that are marked as default.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
sharhalakis created this revision.Dec 24 2018, 8:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 24 2018, 8:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sharhalakis requested review of this revision.Dec 24 2018, 8:25 PM
cfeck added a subscriber: cfeck.Jan 17 2019, 11:15 PM
cfeck added inline comments.
src/pulseaudio.cpp
300–301

Missing Space: ) &&

sharhalakis marked an inline comment as done.

Fixed. I'm not sure if I need to press a button or something to request another review though.

Don't worry, reviewers automatically get notified. :)

filipf added a subscriber: filipf.Jan 18 2019, 12:54 AM

For context, I filed the bug report (https://bugs.kde.org/show_bug.cgi?id=395466) and then David fixed it in D13568.

Since I don't think PulseEffects becomes the default device, this should be fine.

drosca accepted this revision.Jan 18 2019, 10:43 AM
This revision is now accepted and ready to land.Jan 18 2019, 10:43 AM

Thanks for the review. Can you submit it for me? My KDE developer account is disabled, probably because of years of inactivity.

Thanks for the review. Can you submit it for me? My KDE developer account is disabled, probably because of years of inactivity.

I'll need your full name + email then.

Stefanos Harhalakis <v13@v13.gr>

This revision was automatically updated to reflect the committed changes.

Should this be cherry-picked onto the stable branch so it makes it into the upcoming 5.15 release?