Remove hardcoded /usr/share paths in install
ClosedPublic

Authored by davidedmundson on Jan 16 2019, 1:41 AM.

Details

Summary

We can't assume where breeze color files are installed.

If this was a user facing app we should use XDG_DATA_DIRS but as this is
purely used as an install script it should use the data configured in
the found breeze.

There's still a tonne of hardcoded strings in the scripts, but at least
they're now in paths we don't hit.

Test Plan

Now builds on my machine.

Diff Detail

Repository
R98 Breeze for Gtk
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7175
Build 7193: arc lint + arc unit
davidedmundson created this revision.Jan 16 2019, 1:41 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2019, 1:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 16 2019, 1:41 AM
zzag accepted this revision.Jan 16 2019, 9:37 AM
zzag added a subscriber: zzag.
zzag added inline comments.
src/build_theme.sh
66–73

You forgot to indent this one. :-)

91

Probably unrelated whitespace change.

This revision is now accepted and ready to land.Jan 16 2019, 9:37 AM
This revision was automatically updated to reflect the committed changes.
rikmills added a subscriber: rikmills.EditedJan 17 2019, 7:39 AM

Build fails now on Kubuntu Cosmic and Disco builds.

EDIT: ignore for now. My breeze was not up to date with the latest change to export BREEZE_COLOR_INSTALL_ROOT