Differential D18049

[libkwineffects] Port the remaining bits of API to dynamic dispatch
ClosedPublic
Actions

Authored by zzag on Jan 7 2019, 5:28 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

R108:ef7b553cb4e0: [libkwineffects] Port the remaining bits of API to dynamic dispatch

Summary

7834bec52a6770b16087be07a94cca6a165482a6 missed to port minimize and
unminimize to dynamic dispatch. In addition to that, we don't benefit
from QMetaObject::invokeMethod so port addRepaint and addLayerRepaint
to dynamic dispatch as well.

Diff Detail

Repository

R108 KWin

Branch

virtual-dispatch

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 6755
Build 6773: arc lint + arc unit

zzag created this revision.Jan 7 2019, 5:28 PM

Restricted Application added a project: KWin. · View Herald TranscriptJan 7 2019, 5:28 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Jan 7 2019, 5:28 PM

Harbormaster completed remote builds in B6751: Diff 48880.Jan 7 2019, 5:28 PM

Toplevel::addRepaint and Toplevel::addLayerRepaint no longer has to be Q_INVOKABLE.

Harbormaster completed remote builds in B6754: Diff 48883.Jan 7 2019, 5:46 PM

Technically that's an API break on kwin scripting as TopLevel is exposed there.

I can't think why any script would need them, but we made a point of documenting them: https://techbase.kde.org/Development/Tutorials/KWin/Scripting/API_4.9#Functions_4

In D18049#388288, @davidedmundson wrote:

Technically that's an API break on kwin scripting as TopLevel is exposed there.

I can't think why any script would need them, but we made a point of documenting them: https://techbase.kde.org/Development/Tutorials/KWin/Scripting/API_4.9#Functions_4

Oh, darn. You're right.

Back to q_invokable

Harbormaster completed remote builds in B6755: Diff 48884.Jan 7 2019, 5:54 PM

Another potential API break: making EffectWindow::closeWindow() non-const. Though I hope it would be okay to break compatibility there, it doesn't make sense to have that method const.

missed to port minimize and unminimize to dynamic dispatch.

It wasn't exactly "missed", the commit description says it's porting all property getters as they were the only thing potentially called every frame.
But we may as well kill this moc-trampoline entirely. Ship it

This revision is now accepted and ready to land.Jan 7 2019, 6:53 PM

Closed by commit R108:ef7b553cb4e0: [libkwineffects] Port the remaining bits of API to dynamic dispatch (authored by zzag). · Explain WhyJan 7 2019, 7:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/test_window_paint_data.cpp (50 lines)
M			effects.h (10 lines)
M			effects.cpp (46 lines)
M			libkwineffects/kwineffects.h (16 lines)
M			libkwineffects/kwineffects.cpp (44 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48880	3f13a49		Jan 7 2019, 5:28 PM	★	★
Diff 2	48883	3f13a49	Toplevel::addRepaint and Toplevel::addLayerRepaint no longer has to be…	Jan 7 2019, 5:46 PM	★	★
Diff 3	48884	3f13a49	Back to q_invokable	Jan 7 2019, 5:54 PM	★	★
Diff 4	48910	3f13a49	R108:ef7b553cb4e036463b4ad5762a997ff52f92ce8b	Jan 7 2019, 7:40 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
aa5b8f90c8ea	fc0d9bb27970	3f13a493c8de	Vlad Zagorodniy	[libkwineffects] Port the remaining bits of API to dynamic dispatch (Show More…)	Jan 7 2019, 4:29 PM