| ngraham | |
| mgallien |
| Elisa |
Assign SpaceBar key as the global shortcut for play/pause action. Most of the media player out there already use spacebar as the global shortcut for play/pause action. So, it would be good to do the same for Elisa.
Modified ElisaMainWindow.qml to add the shortcut component.
Modified MediaPlayerControl.qml to prevent elements from getting focus as it causes interference with the shortcut keypressed events.
BUG: 392989
FIXED-IN: elisa 0.3.80
| Lint Skipped |
| Unit Tests Skipped |
Thanks for the patch! There are a lot of unintentional trailing whitespace changes here. Do you think you can clean those up?
Thanks!
This works great, I love it. It's up to the Elisa devs of course, but this gets a thumbs up from me.
Thanks for your patch.
Could you please rebase it on top of your previous patch or use arcanist (https://secure.phabricator.com/book/phabricator/article/arcanist/) to submit them ?
The current patch did not apply correctly when trying to do so with "arc patch D17994" command.
Can you also add the ability to configure it like you did in D18017 ?
Made the shortcut configurable. I actually did a "git pull" and updated the feature out from a fresh repo. It should work now.
You should probably also update the diff using it, because it has context. Otherwise you can do git diff -U9999 > foo.diff to make a diff file with context in it.
I notice that after navigating to an element using the tab key, hitting the spacebar does correctly trigger that element rather than doing play/pause, but then the just-triggered element is no longer selected afterwards. We should probably preserve that.
maybe i need to do the job using event filter instead of the usual shortcut mechanism used by Elisa
@ngraham can you please specify on which element did you navigate to. I tried to replicate it, it does as you mentioned, on the navigation action bar. But not on the elements outside it. And the purpose of the patch was to perform playpause action irrespective of focus. So probably blocking all the tab events of navigation action bar should do the job.
For example the mute/unmute button.
We don't want to break keyboard navigation via tab though. Perhaps when tab-navigating, items should be triggered with the return key?
Essentially, here's when I had in mind:
In other words, Elisa should make a distinction between items deliberately focused using the tab key and items focused "by accident" just in the course of using the app with the mouse.
Does that make sense?
So maybe it should, or maybe using the space bar should continue to click the selected element when that element was selected using the tab key.
Ok lets look into it. It might be done through an ugly hack using event filters, but i have to research up a bit.
I have updated the diff. Elements focused using tab key will be triggered by Return Key. SpaceBar is assigned global shortcut for play-pause action and won't trigger elements focussed using tab key. Should work for most part.
Thanks for your work. It works really well.
I have one question. Do you have an idea why the return key needs a special handling whereas QWidget based application seem to work fine ?
I have one more issue. It could be really nice if you could deactivate the event filter when the shortcut is assigned something different from space key.
Please fix also the issues reported by @shubham .
Ok i will do as you have mentioned. I had to handle return keys separately as they dont trigger actions.
Maybe this is something we should fix at the QQC2-desktop-style level so all QQC/QML/Kirigami apps can get it too?