Details
Not landable until more testing and data integrity checks.
Test Data Results
Tested on marlin. Some Junk Data sent with expected data - rizzitello
Diff Detail
- Repository
- R232 AtCore
- Branch
- writeToSd
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6679 Build 6697: arc lint + arc unit
src/plugins/marlinplugin.cpp | ||
---|---|---|
133 | This class does not currently include QFileInfo is that lighter then doing this one call? | |
src/plugins/marlinplugin.h | ||
80 |
As soon as i see a plugin other then marlin that needs this function. We only have sd support on marlin and repetier so far and repetier uses full names |
src/plugins/marlinplugin.cpp | ||
---|---|---|
133 | There is at least 3 places to use qfileinfo in this patch. |
testclient/mainwindow.cpp | ||
---|---|---|
643 | wait, what? |
src/core/atcore.cpp | ||
---|---|---|
892 | I belive this function shouldn't return bool, | |
src/plugins/marlinplugin.cpp | ||
64–71 | temp = QStringLiteral("M29"); | |
132 | QLatin1Char('.') ? |