Differential D17859

Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11
ClosedPublic
Actions

Authored by eduisters on Dec 29 2018, 7:30 PM.

Details

Reviewers

nicolasfella

Group Reviewers

KDE Connect

Commits

R225:9fb780f9197c: Migrate from PreferenceActivity to PreferenceFragment because it has been…

Summary

PreferenceActivity has been deprecated since Android 3.0 API 11 in favour of PreferenceFragment


Before

After

Test Plan

Apply patch and observe that the DeviceSettings and PluginSettings screen behave as expected
and now also follow material design guidelines

Diff Detail

Repository

R225 KDE Connect - Android application

Branch

replace_preference_activity

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6546
Build 6564: arc lint + arc unit

eduisters created this revision.Dec 29 2018, 7:30 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 29 2018, 7:30 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

eduisters requested review of this revision.Dec 29 2018, 7:30 PM

Harbormaster completed remote builds in B6462: Diff 48369.Dec 29 2018, 7:30 PM

eduisters edited the summary of this revision. (Show Details)Dec 29 2018, 7:38 PM

eduisters added a reviewer: KDE Connect.

Fix NPE

Harbormaster completed remote builds in B6529: Diff 48484.Jan 1 2019, 5:30 PM

Improved state saving

Harbormaster completed remote builds in B6546: Diff 48514.Jan 2 2019, 10:52 AM

nicolasfella accepted this revision.Jan 5 2019, 7:03 PM

This revision is now accepted and ready to land.Jan 5 2019, 7:03 PM

eduisters added inline comments.Jan 5 2019, 7:13 PM

src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneSettingsFragment.java
75	Typo: not => no
src/org/kde/kdeconnect/UserInterface/PluginSettingsFragment.java
59	Typo: delete call

eduisters marked 2 inline comments as done.Jan 6 2019, 11:25 AM

Closed by commit R225:9fb780f9197c: Migrate from PreferenceActivity to PreferenceFragment because it has been… (authored by eduisters). · Explain WhyJan 6 2019, 11:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		AndroidManifest.xml (20 lines)
A	M	res/layout/activity_device_settings.xml (7 lines)
M		res/layout/preference_with_button.xml (11 lines)
M		res/values/strings.xml (1 line)
M		res/xml/findmyphoneplugin_preferences.xml (5 lines)
M		src/org/kde/kdeconnect/BackgroundService.java (1 line)
M		src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java (2 lines)
M		src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhonePlugin.java (5 lines)
A	M	src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneSettingsFragment.java (113 lines)
M		src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java (1 line)
M		src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java (16 lines)
M		src/org/kde/kdeconnect/Plugins/Plugin.java (19 lines)
M		src/org/kde/kdeconnect/Plugins/RemoteKeyboardPlugin/RemoteKeyboardPlugin.java (4 lines)
M		src/org/kde/kdeconnect/Plugins/RemoteKeyboardPlugin/RemoteKeyboardService.java (8 lines)
M		src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java (17 lines)
V		src/org/kde/kdeconnect/Plugins/SharePlugin/{ShareSettingsActivity.java → ShareSettingsFragment.java}
V		src/org/kde/kdeconnect/Plugins/SharePlugin/{ShareSettingsFragment.java ← ShareSettingsActivity.java} (64 lines)
M		src/org/kde/kdeconnect/UserInterface/DeviceSettingsActivity.java (94 lines)
A	M	src/org/kde/kdeconnect/UserInterface/DeviceSettingsFragment.java (175 lines)
M		src/org/kde/kdeconnect/UserInterface/PluginPreference.java (36 lines)
D	M	src/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java (68 lines)
A	M	src/org/kde/kdeconnect/UserInterface/PluginSettingsFragment.java (81 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48369	f684fbe		Dec 29 2018, 7:30 PM	★	★
Diff 2	48484	f684fbe	- Fix NPE	Jan 1 2019, 5:30 PM	★	★
Diff 3	48514	f684fbe	- Improved state saving	Jan 2 2019, 10:52 AM	★	★
Diff 4	48788	045e329	R225:9fb780f9197ca92b8790890f99fd64de532ee701	Jan 6 2019, 11:36 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a6e97e163d22	b55a39b497fa	0965ef567c1a	Erik Duisters	Improved state saving	Jan 2 2019, 10:51 AM
0965ef567c1a	93cbb2c95e8b	97ea52b82a1c	Erik Duisters	Fix NPE	Jan 1 2019, 5:30 PM
97ea52b82a1c	c6d7fc65d391	f684fbe8eff5	Erik Duisters	Migrate from PreferenceActivity to PreferenceFragment because it has been… (Show More…)	Dec 29 2018, 7:27 PM