Correct includes
ClosedPublic

Authored by patrickelectric on Dec 23 2018, 1:45 PM.

Details

Summary

Remove unneeded includes, add correct includes, move includes h <-> cpp

Diff Detail

Repository
R319 Konsole
Branch
remove_includes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6403
Build 6421: arc lint + arc unit
Restricted Application added a project: Konsole. · View Herald TranscriptDec 23 2018, 1:45 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
patrickelectric requested review of this revision.Dec 23 2018, 1:45 PM

Are you using a tool to determine this?

hindenburg retitled this revision from Correct QApplication include to Correct includes.Dec 23 2018, 6:29 PM
hindenburg edited the summary of this revision. (Show Details)

Are you using a tool to determine this?

Yep, I'm building a tool for that :)

Only one question - otherwise looks fine

src/SessionController.h
25

This is the only concern I see - it compiles because it it pulling QList from the ProfileManager.h include - shouldn't the QList include be moved to SessionController.cpp ?

patrickelectric edited the summary of this revision. (Show Details)

Add missing QList

hindenburg accepted this revision.Dec 29 2018, 1:45 AM
hindenburg edited the summary of this revision. (Show Details)

thanks

This revision is now accepted and ready to land.Dec 29 2018, 1:47 AM
This revision was automatically updated to reflect the committed changes.