if special "xdg-data" string is used for shared path,
we have no need for the wrapper any more,
since that shared path is also mounted within $XDG_DATA_HOME inside sandbox
Details
- Reviewers
apol - Commits
- R256:3e28c7cdc899: remove wrapper script
Diff Detail
- Repository
- R256 Flatpak packaging for KDE Applications
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6322 Build 6340: arc lint + arc unit
Sorry, I'm new to Arcanist.
I need to publish the commits for review separately.
Please, help
Why is this better? please provide a better description.
org.kde.discover.json | ||
---|---|---|
140 | Don't put this last, this will break binary-factory builds. |
@apol well, I believe it makes navigating and editing more easily, and better corresponds to idea of having all needed information to build the software in one manifest file.
The wrapper role is too minor for pushing it to a separate file.
I wish it wouldn't be needed at all, but we just have to keep it due restrictions flatpak has currently.
The clue part here is removing the wrapper.sh file.
Also, I don't think we should make a separate module just for the wrapper.
org.kde.discover.json | ||
---|---|---|
140 | Will that build in binary-factory? |
@apol Last but not least, you could give me a New Year present accepting this patch :-P