This is a preparation step to move this to ECM (or possibly CMake),
which makes sense now that qtbase is using this too (for Qt6).
Details
Details
- Reviewers
krop - Group Reviewers
Build System - Commits
- R108:3bb07ef12d3e: Bring FindFontconfig.cmake up to ECM standards
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- master
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6067 Build 6085: arc lint + arc unit
| cmake/modules/FindFontconfig.cmake | ||
|---|---|---|
| 10 | shall be FONTCONFIG_INCLUDE_DIRS (https://cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names) This link also suggests the variable names shall be exact-case FONTCONFIG_ → Fontconfig_ | |
| 27–50 | Remove this condition. This is not recommended anymore | |
| 56–57 | Delete this if() / endif(). Not needed anymore since ages. | |
| 88 | There's no version check, does it matter? | |
| 97–104 | endif() | |
| 118 | Remove the dot, feature_summary() adds a comma after the description | |
| cmake/modules/FindFontconfig.cmake | ||
|---|---|---|
| 29 | You need a fallback method for platforms where pkgconfig isn't usable. fontconfig.h defines FC_MAJOR, FC_MINOR, FC_REVISION | |
| 60 | Now that you have Fontconfig_VERSION, please use the second form: find_package_handle_standard_args(Fontconfig FOUND_VAR Fontconfig_FOUND REQUIRED_VARS Fontconfig_LIBRARIES Fontconfig_INCLUDE_DIRS VERSION_VAR Fontconfig_VERSION) | |