Differential D17411

Use butterknife for view binding
ClosedPublic
Actions

Authored by eduisters on Dec 7 2018, 6:05 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:9f498f81277d: Use butterknife for view binding
Summary

Use butterknife for view binding

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Dec 7 2018, 6:05 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 7 2018, 6:05 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Dec 7 2018, 6:05 PM
nicolasfella accepted this revision.Dec 7 2018, 7:32 PM
nicolasfella added a subscriber: nicolasfella.

Looks fine to me. I can't say much to Butterknife, but it seems to work fine

src/org/kde/kdeconnect/UserInterface/MainActivity.java
56–59

Any reason why they are not private any more?

This revision is now accepted and ready to land.Dec 7 2018, 7:32 PM
eduisters added inline comments.Dec 7 2018, 7:53 PM
src/org/kde/kdeconnect/UserInterface/MainActivity.java
56–59

Butterknife can't set private members. It basically generates code to do what it needs to do in the same package. You can see the code in build/generated/source/apt/..../MainActivity_ViewBinding.java

Closed by commit R225:9f498f81277d: Use butterknife for view binding (authored by eduisters). · Explain WhyDec 8 2018, 1:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47103

View Options

build.gradle

Loading...
View Options

src/org/kde/kdeconnect/UserInterface/MainActivity.java

Loading...