Add special support for block characters
ClosedPublic

Authored by sandsmark on Dec 2 2018, 4:42 AM.

Details

Summary

Similar to the line chars, block chars look much better
if we handle them ourselves.

Test Plan

cat tests/boxes.txt and cat tests/UTF-8-demo.txt

Diff Detail

Repository
R319 Konsole
Lint
Lint Skipped
Unit
Unit Tests Skipped
sandsmark created this revision.Dec 2 2018, 4:42 AM
Restricted Application added a project: Konsole. · View Herald TranscriptDec 2 2018, 4:42 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
sandsmark requested review of this revision.Dec 2 2018, 4:42 AM
sandsmark updated this revision to Diff 46839.Dec 4 2018, 3:59 PM

fix format of patch for phabricator

hindenburg edited the summary of this revision. (Show Details)Dec 6 2018, 3:49 PM
hindenburg added inline comments.Dec 7 2018, 3:26 PM
src/TerminalDisplay.cpp
941–944

does it make sense here to add an upper bound to make this clearer?

sandsmark updated this revision to Diff 47050.Dec 7 2018, 5:44 PM
sandsmark marked an inline comment as done.

Fixed the bound, added some comments

This revision is now accepted and ready to land.Dec 10 2018, 12:23 AM
This revision was automatically updated to reflect the committed changes.