Differential D17360

Added "Transparent with light text" theme for Desktop Notes
ClosedPublic
Actions

Authored by IamMaxim on Dec 4 2018, 7:42 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R114:0230b5f5e332: Added "Transparent with light text" theme for Desktop Notes
Summary

This commit adds one more simple theme for Desktop Notes, for ones who prefer the dark background and want to put sticky notes on it.

BUG: 386833

Before:

After:

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
IamMaxim created this revision.Dec 4 2018, 7:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 4 2018, 7:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
IamMaxim requested review of this revision.Dec 4 2018, 7:42 PM
IamMaxim retitled this revision from Added "Transparent with light text" theme to Added "Transparent with light text" theme for Desktop Notes.Dec 4 2018, 8:05 PM
IamMaxim edited the summary of this revision. (Show Details)
IamMaxim added a reviewer: Plasma.
davidedmundson accepted this revision.Dec 4 2018, 8:10 PM
This revision is now accepted and ready to land.Dec 4 2018, 8:10 PM
davidedmundson added a comment.Dec 4 2018, 8:11 PM

There's a bug number for this somewhere, can you have a look

IamMaxim updated this revision to Diff 46870.Dec 4 2018, 8:36 PM
IamMaxim edited the summary of this revision. (Show Details)

I've found a bug for that and added theme entry into preferences right-click menu.

ngraham edited the summary of this revision. (Show Details)Dec 4 2018, 8:45 PM
ngraham added a comment.Dec 4 2018, 11:12 PM

Thanks for the patch @IamMaxim! Can you provide your email address so we can land it with your authorship information?

IamMaxim added a comment.Dec 5 2018, 7:50 AM

Of course, it's g.maxim.stepanoff@gmail.com

shubham added a subscriber: shubham.Dec 5 2018, 10:15 AM

Congrats on your first patch.

Closed by commit R114:0230b5f5e332: Added "Transparent with light text" theme for Desktop Notes (authored by IamMaxim, committed by ngraham). · Explain WhyDec 6 2018, 1:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46870

View Options

applets/notes/package/contents/ui/configAppearance.qml

Loading...
View Options

applets/notes/package/contents/ui/main.qml

Loading...