No big visible changes, but simplifies and modernizes the code
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Commits
- R120:76eba93be27f: Port to QQC2 and FormLayout
used all functionality of the systray config dialog
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Looking good code-wise!
Could we take the opportunity to improve the layout too? This huge list of checkboxes is entirely left-aligned, with a huge gaping chasm of whitespace on the right. Seems like we could benefit from centering it as per the typical Kirigami FormLayout appearance.
Wait! Isn't the header labels supposed to be on the right? They are also supposed to be aligned to the first item in the series of checkboxes.
Current:
LABEL
- ITEM
Proper:
LABEL [x] ITEM
That's true, in this case where not one of the items has a left label, we generally like to use left labels as pseudo section headers, like in Dolphin's settings window.
no
Current:
LABEL
- ITEM
Proper:
LABEL [x] ITEM
no, formalyout titles are titles on top of the section.
They used to always be left aligned, but after a long discussion they were moved towards the center as well.
This is the reference implementation of a correct form layout in the kirigami gallery: