Port to QQC2 and FormLayout
ClosedPublic

Authored by mart on Nov 28 2018, 11:08 AM.

Details

Summary

No big visible changes, but simplifies and modernizes the code

Test Plan

used all functionality of the systray config dialog

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Nov 28 2018, 11:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 28 2018, 11:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 28 2018, 11:08 AM

Looking good code-wise!

Could we take the opportunity to improve the layout too? This huge list of checkboxes is entirely left-aligned, with a huge gaping chasm of whitespace on the right. Seems like we could benefit from centering it as per the typical Kirigami FormLayout appearance.

mart updated this revision to Diff 46465.Nov 29 2018, 1:30 PM
  • center the layout
ngraham accepted this revision.Nov 29 2018, 2:47 PM

Lovely :)

This revision is now accepted and ready to land.Nov 29 2018, 2:47 PM
In D17212#368048, @mart wrote:

Wait! Isn't the header labels supposed to be on the right? They are also supposed to be aligned to the first item in the series of checkboxes.

Current:

LABEL

  • ITEM

Proper:

LABEL [x] ITEM

That's true, in this case where not one of the items has a left label, we generally like to use left labels as pseudo section headers, like in Dolphin's settings window.

mart added a comment.Nov 29 2018, 4:02 PM
In D17212#368048, @mart wrote:

Wait! Isn't the header labels supposed to be on the right? They are also supposed to be aligned to the first item in the series of checkboxes.

no

Current:

LABEL

  • ITEM

    Proper:

    LABEL [x] ITEM

no, formalyout titles are titles on top of the section.
They used to always be left aligned, but after a long discussion they were moved towards the center as well.
This is the reference implementation of a correct form layout in the kirigami gallery:

This revision was automatically updated to reflect the committed changes.