Differential D17307

Fix unreadable Falkon logo text when using a dark theme
ClosedPublic
Actions

Authored by GB_2 on Dec 2 2018, 1:13 PM.

Details

Reviewers
drosca
Group Reviewers
Falkon
Commits
R875:3b51982c5dce: Fix unreadable Falkon logo text when using a dark theme
Summary

BUG: 400262
https://bugs.kde.org/show_bug.cgi?id=400262

This puts a light rounded rectangle behind the logo, so the logo text is readable when using a dark theme.

Test Plan

Open the about window (Application Menu -> About Falkon).

Diff Detail

Repository
R875 Falkon
Lint
Lint Skipped
Unit
Unit Tests Skipped
GB_2 created this revision.Dec 2 2018, 1:13 PM
Restricted Application added a subscriber: falkon. · View Herald TranscriptDec 2 2018, 1:13 PM
GB_2 requested review of this revision.Dec 2 2018, 1:13 PM
GB_2 edited the test plan for this revision. (Show Details)Dec 2 2018, 1:19 PM
GB_2 edited the summary of this revision. (Show Details)
GB_2 edited the test plan for this revision. (Show Details)
drosca added a subscriber: drosca.Dec 2 2018, 1:22 PM

That looks good, but this image is also used in falkon:about page, please test that it is fine there too.

GB_2 updated this revision to Diff 46702.Dec 2 2018, 1:23 PM

Remove unneeded lines.

GB_2 added a comment.Dec 2 2018, 1:26 PM
In D17307#369966, @drosca wrote:

That looks good, but this image is also used in falkon:about page, please test that it is fine there too.

drosca accepted this revision.Dec 2 2018, 1:27 PM
This revision is now accepted and ready to land.Dec 2 2018, 1:27 PM
Closed by commit R875:3b51982c5dce: Fix unreadable Falkon logo text when using a dark theme (authored by GB_2, committed by cullmann). · Explain WhyDec 11 2018, 8:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/data/icons/other/about.svg (351 lines)

Diff 46702

View Options

src/lib/data/icons/other/about.svg

Loading...