Port more search providers to HTTPS
ClosedPublic

Authored by vkrause on Nov 17 2018, 10:05 AM.

Details

Summary

Those are mostly services with more complex URLs changes than just adding
the extra 's' to get to HTTPS. The exception is ethicle.com which redirects
to ecosia.com without supporting HTTPS itself, so just merge their desktop
files.

There are still a few ones left not using HTTPS now, but those services
actually seem to not support that at all. Do we want to support such
insecure services here at all?

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Nov 17 2018, 10:05 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 17 2018, 10:05 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Nov 17 2018, 10:05 AM
apol accepted this revision.Nov 19 2018, 1:34 AM
apol added a subscriber: apol.

LGTM.

About the rest, probably not, do you think that there's any that would be a big loss? I would assume by now that if they don't work with https it's probably because it's abandoned.

This revision is now accepted and ready to land.Nov 19 2018, 1:34 AM
In D16946#361950, @apol wrote:

About the rest, probably not, do you think that there's any that would be a big loss? I would assume by now that if they don't work with https it's probably because it's abandoned.

The remaining non-https ones are:

  • ctan_cat
  • dictfr
  • freecode
  • freedb
  • grec
  • hyperdictionary[_thesaurus]
  • magnatune
  • rae
  • uspto
  • voila

Some of them might be broken, I can only automate testing if the service responds, not if it responds with something sensible, and sometimes that's even hard to determine manually...

This revision was automatically updated to reflect the committed changes.