Fixed Header in 3 plugins: Run Command, Multimedia control, Remote input
Details
Details
- Reviewers
brute4s99 - Group Reviewers
KDE Connect
build the Android APK and analyze the Header in Run Command, Remote input and Multimedia control plugins.
Diff Detail
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Branch
- header_names_fixes (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5291 Build 5309: arc lint + arc unit
Comment Actions
Are there strings (like "@string/remote_control") which are no longer in use? If so, those should probably be removed from res/values/strings/strings.xml
AndroidManifest.xml | ||
---|---|---|
138 | Use pref_plugin_mpris for consistency with the others? Or even better, since these strings are not used for preferences anymore, maybe we could call them plugin_mpris_controls, plugin_runcommand, etc. And change the references in the code. |
Comment Actions
I have uploaded the requested changes to new arc diff, since this branch was not working anymore.
Please shift discussion to : https://phabricator.kde.org/D17250