Differential D17125

Title (/Header) in Run Command, Remote Input and Multimedia control was "Remote control". This patch fixes the said Title (/Header) to their respective plugin titles.
AbandonedPublic
Actions

Authored by nicolasfella on Nov 23 2018, 6:10 PM.

Details

Reviewers
brute4s99
Group Reviewers
KDE Connect
Summary

Fixed Header in 3 plugins: Run Command, Multimedia control, Remote input

Test Plan

build the Android APK and analyze the Header in Run Command, Remote input and Multimedia control plugins.

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
header_names_fixes (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5291
Build 5309: arc lint + arc unit
brute4s99 created this revision.Nov 23 2018, 6:10 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 23 2018, 6:10 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
brute4s99 requested review of this revision.Nov 23 2018, 6:10 PM
sredman added a subscriber: sredman.Nov 24 2018, 1:02 AM

Are there strings (like "@string/remote_control") which are no longer in use? If so, those should probably be removed from res/values/strings/strings.xml

albertvaka added a subscriber: albertvaka.Nov 28 2018, 1:19 PM
albertvaka added inline comments.
AndroidManifest.xml
138

Use pref_plugin_mpris for consistency with the others? Or even better, since these strings are not used for preferences anymore, maybe we could call them plugin_mpris_controls, plugin_runcommand, etc. And change the references in the code.

brute4s99 added a comment.EditedNov 30 2018, 4:56 AM

I have uploaded the requested changes to new arc diff, since this branch was not working anymore.
Please shift discussion to : https://phabricator.kde.org/D17250

nicolasfella commandeered this revision.Nov 30 2018, 4:55 PM
nicolasfella abandoned this revision.
nicolasfella added a reviewer: brute4s99.

Revision Contents
Changeset List

PathPackages
MAndroidManifest.xml (6 lines)

Diff 46086

View Options

AndroidManifest.xml

Loading...