Atelier Clazy-tidy
ClosedPublic

Authored by rizzitello on Nov 22 2018, 6:27 PM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava
Commits
R231:d1876f5b2e17: Use = for deconstructor Initialize vars without defaults Set parents Signed…
R231:ddfea1aa56dd: Const Ref for name Use default deconstructor Set Parents
R231:8e95b60ac30e: Remove Namespace Use = default for deconstructor
R231:b446c8547e38: Use = for deconstructor
R231:d8b5b03ce571: Use auto
R231:9f7afcc7c7a4: Use auto Initialize vars without defaults Use = default deconstructor Set…
R231:cfe0234d9ffb: Reduce qApp calls Use QString for empty QString Signed-off-by: Chris Rizzitello…
R231:8034f7bbad64: Use auto Remove else after return Initialize var without defaults Don't use…
R231:fecf7dde7746: Use = default for deconstructor
R231:d189a28ceccc: Using to replace typedef Set Parent Use default deconstructor Signed-off-by…
R231:4f98526c1110: Use = default for deconstructor
R231:111eff846378: Use auto Initialize vars without defaults remove else after return Set…
R231:fe6f950cd00c: checkTemperature Show index only for extruder's temperatures.
R231:04b186cc69d4: Atelier Clazy-tidy
R231:60670232b4df: Use auto Const Ref file Use = default for deconstructor
R231:a0e925a4af49: Else after return Use R to reduce special char treatment Use default…
R231:fc590f2aae9e: Use default deconstuctor Set parents Automaticly select top entry Fix typo…
R231:ecad265eecb0: Use = for deconstructor
R231:ee5cb7237a24: Use = default for deconstructor
R231:64cf5f11905f: Use = for deconstructor
R231:0298d46ddcb1: Remove else after return Remove Unneeded Debug calls Use = default for…
Summary

Resolve Clang-tidy / Clazy "issues" They include

  • QStringLiteral is slow for empty strings so use QString("")
  • More use of auto to cut back on Object *= new object...
  • more things with parents
  • Use default deconstuctors
  • Initialization of variables without defaults.
  • Const Refs to avoid extra copies
  • &More things

Diff Detail

Repository
R231 Atelier
Branch
clazy-tidy
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5278
Build 5296: arc lint + arc unit
rizzitello requested review of this revision.Nov 22 2018, 6:27 PM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Nov 22 2018, 6:32 PM
rizzitello added a project: Atelier.
rizzitello added a subscriber: Atelier.
rizzitello edited the summary of this revision. (Show Details)
  • Internal Review
rizzitello edited the summary of this revision. (Show Details)Nov 22 2018, 10:47 PM
rizzitello updated this revision to Diff 46057.Nov 23 2018, 4:06 AM
  • More Clazy fixes
rizzitello updated this revision to Diff 46059.Nov 23 2018, 4:43 AM
  • Split a change off
rizzitello updated this revision to Diff 46061.Nov 23 2018, 5:34 AM
  • fix Typo in listWidget name
rizzitello added inline comments.Nov 23 2018, 5:39 AM
src/mainwindow.cpp
474

I Did not forget this button see D17116

tcanabrava accepted this revision.Nov 23 2018, 10:35 AM

Just a nitpick, an empty QString should be QString(), not QString("")

This revision is now accepted and ready to land.Nov 23 2018, 10:35 AM

Just a nitpick, an empty QString should be QString(), not QString("")

Yes your right. Ill fix that.

rizzitello updated this revision to Diff 46081.Nov 23 2018, 3:17 PM
  • QString() for empty strings
rizzitello updated this revision to Diff 46152.Nov 24 2018, 7:12 PM
  • Split change
rizzitello updated this revision to Diff 46156.Nov 24 2018, 8:02 PM
Split Change for MainWindow::askToSave
laysrodrigues added inline comments.Nov 25 2018, 12:30 AM
src/widgets/3dview/fileloader.cpp
29

ns? can you clarify the name of this namespace, because ns short for namespace doesn't sound clear

rizzitello updated this revision to Diff 46171.Nov 25 2018, 1:01 AM
  • Use static const private members instead of namespace
rizzitello marked an inline comment as done.Nov 25 2018, 1:09 AM
  • Static const for welcome widget
  • Fix some typo's in welcome widget
rizzitello marked an inline comment as done.Dec 1 2018, 12:34 PM
rizzitello updated this revision to Diff 46612.Dec 1 2018, 12:39 PM
  • Remove new empty line
laysrodrigues accepted this revision.Dec 11 2018, 3:57 PM
patrickelectric requested changes to this revision.Dec 11 2018, 7:37 PM
patrickelectric added inline comments.
src/dialogs/profilesdialog.cpp
223–226

get with reference

src/main.cpp
68

auto mainWindow

src/widgets/atcoreinstancewidget.cpp
148

QStringLiteral

src/widgets/atcoreinstancewidget.h
71–72

why only this ones are nullptr ?

src/widgets/bedextruderwidget.cpp
51

why are you removing debug information ?

This revision now requires changes to proceed.Dec 11 2018, 7:37 PM
rizzitello marked 5 inline comments as done.
  • Patricks suggestions
  • cleanup nullptrs in mainwindows
rizzitello added inline comments.Dec 11 2018, 10:13 PM
src/widgets/bedextruderwidget.cpp
51

Redundant since it is logged.

  • Remove unused QDebug call
laysrodrigues accepted this revision.Dec 13 2018, 4:44 PM
patrickelectric accepted this revision.Dec 17 2018, 1:30 PM
This revision is now accepted and ready to land.Dec 17 2018, 1:30 PM
rizzitello closed this revision.Dec 17 2018, 1:34 PM