For that also deduplicate any data extraction & conversion logic
in helper methods for consistency
Details
Details
- Reviewers
broulik - Group Reviewers
Plasma - Commits
- R114:0d379c5957e2: [weather] Fix broken observation display for temperature of 0 °
Observation temperature of 0 ° no longer is shown as empty string,
all other data is shown as before (tested by hardcoding 0 as temperature in
the dataengine, to not have to wait for the next evening ;) ).
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- fix0DegreeTemperature
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5238 Build 5256: arc lint + arc unit
Comment Actions
Observation temperature of 0 ° no longer is shown as empty string,
Classic JS! well found.
It looks OK to me, but hopefully @broulik can have a look as quirky JS is his specialty.
Comment Actions
- use var data = weatherDataSource.currentData || {}; to simplify rest
- use typeof number !== "undefined"