Use 72 denominator when calculating icon size; this lets up cover a better range of hi-DPI screens with the
correct size icon (48px)
Details
Details
before: (32 px @162 DPI)
after: (48px @162 DPI)
Diff Detail
Diff Detail
- Repository
- R231 Atelier
- Branch
- lateralIconSize
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5073 Build 5091: arc lint + arc unit
src/mainwindow.cpp | ||
---|---|---|
227 | don't use magic numbers... |
src/mainwindow.cpp | ||
---|---|---|
227 | This is exactly how it was done before but using 96. While 96 is the "standard", using 72 works for the range of hi-dpi density better as the DPI varies slightly depending on physical size and native resolution. This fixes an issue where on the icon is correctly scaled on a 15" Hi-dpi display (DPI is 196) and its not scaled on another 28" Hi-Dpi display with a DPI of 162 . Both screens are 4k and both should be scaled. I adjusted the comment so the number is not magic its explained above the line. I didn't think it was worth making a variable to store a one time use number because as a said it was already done this way before my change. |