[Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless
ClosedPublic

Authored by ngraham on Nov 15 2018, 3:48 PM.

Details

Summary

Currently with Folder-View-on-the-desktop, items' labels become illegibe when the icon size is very small.

This patch implements a minimum width when using on-the-desktop icon view to make sure that the label is never uselessly short when using very small icons.

BUG: 379432
FIXED-IN: 5.12.8

Test Plan

Smallest size, before:


Smallest size, after:

Equal padding on either side of the container itself still works:

There is no change for sizes corresponding to the fourth tick on the slider and beyond

Diff Detail

Repository
R119 Plasma Desktop
Branch
more-room-for-labels-with-tiny-icons (branched from Plasma/5.12)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4979
Build 4997: arc lint + arc unit
ngraham created this revision.Nov 15 2018, 3:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 15 2018, 3:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 15 2018, 3:48 PM
ngraham edited the test plan for this revision. (Show Details)Nov 15 2018, 3:51 PM

Can you check the extraWidth stuff still works? Ie. Whether left and right padding of screen is equal, since you Math.max the entire thing to icon size

ngraham updated this revision to Diff 45555.Nov 16 2018, 12:04 AM

Make sure extraWidth stuff still works properly

ngraham edited the summary of this revision. (Show Details)Nov 16 2018, 12:05 AM
ngraham edited the test plan for this revision. (Show Details)

Friendly ping!

hein accepted this revision.Nov 29 2018, 3:53 PM
This revision is now accepted and ready to land.Nov 29 2018, 3:53 PM
This revision was automatically updated to reflect the committed changes.