Differential D16487

Allow copyblocks to be used together with small QByteArrays.
ClosedPublic
Actions

Authored by stikonas on Oct 28 2018, 5:28 PM.

Details

Reviewers

cjlcarvalho

Commits

R16:2007f2b8ea90: Allow copyblocks to be used together with small QByteArrays.

Summary

Add CopyTargetByteArray. CopySourceByteArray is not implemented yet.

This is only suitable for reading small amount of data such as GPT header
or FAT boot sector location. Not meant for copying whole partition because
data has to be transfered over DBus

Test Plan

Partition Manager correctly determines maximum number of GPT partitions

Diff Detail

Repository

R16 KPMCore

Lint

Lint Skipped

Unit

Unit Tests Skipped

stikonas requested review of this revision.Oct 28 2018, 5:28 PM

stikonas created this revision.

stikonas edited the summary of this revision. (Show Details)

stikonas updated this revision to Diff 44372.Oct 28 2018, 5:31 PM

cjlcarvalho accepted this revision.Oct 28 2018, 11:53 PM

This revision is now accepted and ready to land.Oct 28 2018, 11:53 PM

Closed by commit R16:2007f2b8ea90: Allow copyblocks to be used together with small QByteArrays. (authored by stikonas). · Explain WhyOct 29 2018, 12:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/core/CMakeLists.txt (1 line)
A	M	src/core/copytargetbytearray.h (58 lines)
A	M	src/core/copytargetbytearray.cpp (29 lines)
M		src/plugins/sfdisk/CMakeLists.txt (3 lines)
M		src/plugins/sfdisk/sfdiskbackend.cpp (13 lines)
M		src/util/externalcommand.cpp (9 lines)
M		src/util/externalcommandhelper.h (2 lines)
M		src/util/externalcommandhelper.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44371			Oct 28 2018, 5:26 PM	★	★
Diff 2	44372			Oct 28 2018, 5:31 PM	★	★
Diff 3	44397	9ca63ab	R16:2007f2b8ea9054b92e08247e68b5b4a6df87d881	Oct 29 2018, 12:02 AM	★	★