Add the config to use the system color in Korganizer (see D16377)
ClosedPublic

Authored by ognarb on Oct 23 2018, 10:43 PM.

Diff Detail

Repository
R210 KOrganizer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4176
Build 4194: arc lint + arc unit
ognarb created this revision.Oct 23 2018, 10:43 PM
Restricted Application added a project: KDE PIM. Β· View Herald TranscriptOct 23 2018, 10:43 PM
Restricted Application added a subscriber: kde-pim. Β· View Herald Transcript
ognarb requested review of this revision.Oct 23 2018, 10:43 PM
ognarb retitled this revision from Add the config to use the system color in Korganize (see D16377) to Add the config to use the system color in Korganizer (see D16377).Oct 23 2018, 10:47 PM
mlaurent requested changes to this revision.Oct 24 2018, 4:57 AM
mlaurent added a subscriber: mlaurent.

If this settings disable other color settings we need to disable button settings too.
Otherwise user will not understand why he can configure it and it will never used no ?

This revision now requires changes to proceed.Oct 24 2018, 4:57 AM
ognarb updated this revision to Diff 44186.Oct 24 2018, 9:06 PM

Disable some option when useSystemColor is checked

ognarb edited the summary of this revision. (Show Details)Oct 25 2018, 9:42 AM
mlaurent accepted this revision.Oct 26 2018, 5:07 AM

Otherwise it seems ok for me. (Fix just public to private and commit after that)

src/prefs/koprefsdialog.h
72

it can be move as private Q_SLOTS no ?

This revision is now accepted and ready to land.Oct 26 2018, 5:07 AM
ognarb updated this revision to Diff 44235.Oct 26 2018, 6:33 AM
ognarb marked an inline comment as done.

Update to private Q_SLOTS

Otherwise it seems ok for me. (Fix just public to private and commit after that)

Should I request developers access?

Otherwise it seems ok for me. (Fix just public to private and commit after that)

Should I request developers access?

I would suggest so: that would allow you to commit your changes directly after they've been approved.

@mlaurent Can I add you as a supporter for my application? πŸ˜„

"@mlaurent Can I add you as a supporter for my application? πŸ˜„" ok

This revision was automatically updated to reflect the committed changes.