Allow to control the bed dimensions
ClosedPublic

Authored by ervin on Oct 11 2018, 2:34 PM.

Details

Summary

To that effect this patch does the following:

  • introduces a BedProperties element carrying the dimensions;
  • change GridMesh to have the resolution controlled by a property
  • change GridMesh to always be of size 1
  • scale the GridMesh to the right dimensions with a Transform

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 4030
Build 4048: arc lint + arc unit
ervin requested review of this revision.Oct 11 2018, 2:34 PM
ervin created this revision.

Please connect this to the profile data within this commit.

Further work will be needed to account for how this will work with more then one machine connected.

ervin added a comment.Oct 11 2018, 3:09 PM

I'm lacking time to do that, that's why I agreed with Lays she would do that connection. Besides I've no good way to test that stuff and it gives me the creeps, so better have someone with the necessary setup do that bit.

I'm lacking time to do that, that's why I agreed with Lays she would do that connection. Besides I've no good way to test that stuff and it gives me the creeps, so better have someone with the necessary setup do that bit.

I will work on connecting and testing this evening.

ervin added a comment.Oct 11 2018, 3:55 PM

Excellent, thanks!

I got as far as D16144 in connecting these.

src/widgets/3dview/bedproperties.cpp
22

Can you please explain how this is interacts with the other objects to enforce the bed size?

30

Can we use one QSize type variable ?

I belive q QSize is width / height so it would be weird to use for depth.

I belive q QSize is width / height so it would be weird to use for depth.

QSize is a 2D Array sure its label says a W / H value but do we really need to emit signals for both Dimensions ? What cases will we encounter where only one changes? I also think in the context of "Bed Size" W/H works as its s 2d Plain and those are the Dimensions naturally associated with objects of this type.

ervin added a comment.Oct 13 2018, 9:06 AM

Yes, I went for my own properties due to more precise naming, but I admit I don't mind either way on the technical level. So what should I do? Change it or stay as is? You guys seem to disagree a bit. :-)

tcanabrava accepted this revision.Oct 13 2018, 9:09 AM

Yes, I went for my own properties due to more precise naming, but I admit I don't mind either way on the technical level. So what should I do? Change it or stay as is? You guys seem to disagree a bit. :-)

i prefer the more precise naming. :)
Sith, i'm +1'ing this.

This revision is now accepted and ready to land.Oct 13 2018, 9:09 AM

Yes, I went for my own properties due to more precise naming, but I admit I don't mind either way on the technical level. So what should I do? Change it or stay as is? You guys seem to disagree a bit. :-)

i prefer the more precise naming. :)
Sith, i'm +1'ing this.

The value is a QSize up to the bedProperties. we can break it up in to width and depth. but now we have two signals, two slots, two variables. I would rather the path of one variable. If we are to forgo the QSize we need to move from real to int since the bedSize is an int in firmware.

rizzitello requested changes to this revision.Oct 15 2018, 4:22 PM

please See D16144 and expect to read your bed size from the view3d's bedsize property

This revision now requires changes to proceed.Oct 15 2018, 4:22 PM
ervin updated this revision to Diff 43873.Oct 18 2018, 2:57 PM

Rebased on top of D16144, switched to int. Kept the two properties
separate since there's still no agreement in front of me on the way
to go. Again I don't mind either way.

rizzitello accepted this revision.Oct 21 2018, 2:25 PM

Tested with D16144. Works Great!

This revision is now accepted and ready to land.Oct 21 2018, 2:25 PM

@ervin , Im adding some changes to D16144 to account for delta machines. (They have round beds). Could you add a check for depth =0 to make our beds grid a circle with radius of width?

ervin added a comment.EditedOct 24 2018, 12:30 PM

@ervin , Im adding some changes to D16144 to account for delta machines. (They have round beds). Could you add a check for depth =0 to make our beds grid a circle with radius of width?

Heh, Lays warned me about those. I'll have to shy away from that. It's quite some more work and currently I know I won't be able to find the time to get it through.

Would make more sense in a separate patch anyway. I'd rather we get that one integrated as is and then we add the handling for round beds later on.

Feel free to pull me in the review if someone produces the patch for round beds. I'll gladly try to carve some time for reviewing. Still I have too much doubt on me finding time to produce the patch itself. Might happen in the end but it'd be in a few months from now at best.

If you're fine with that, I'll need D16144 to be merged before I can push the current one.

Let me know.

Heh, Lays warned me about those. I'll have to shy away from that. It's quite some more work and currently I know I won't be able to find the time to get it through.
Would make more sense in a separate patch anyway. I'd rather we get that one integrated as is and then we add the handling for round beds later on.
Feel free to pull me in the review if someone produces the patch for round beds. I'll gladly try to carve some time for reviewing. Still I have too much doubt on me finding time to produce the patch itself. Might happen in the end but it'd be in a few months from now at best.
If you're fine with that, I'll need D16144 to be merged before I can push the current one.
Let me know.

Yeah another patch would be fine. I have added the few changes I needed for support to D16144 so we can work on that any time after we get those merged.

laysrodrigues accepted this revision.Oct 24 2018, 10:07 PM
laysrodrigues closed this revision.Nov 1 2018, 1:38 PM
ervin added a comment.Nov 2 2018, 9:58 AM

Thanks for merging it. Sorry for not pushing myself, I've been sick in bed the past few days. Glad it made it though.