Use SerialLayer()->pushCommand in only in processQueue
ClosedPublic

Authored by rizzitello on Oct 14 2018, 5:04 PM.

Details

Summary

Remove special cases where serial()->pushCommand was called and only do it when processing the Queue.

should be applied before D16181

Diff Detail

Repository
R232 AtCore
Branch
consolidateSerialPushes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3927
Build 3945: arc lint + arc unit
rizzitello requested review of this revision.Oct 14 2018, 5:04 PM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Oct 14 2018, 5:06 PM
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
laysrodrigues accepted this revision.Oct 15 2018, 10:32 PM
This revision is now accepted and ready to land.Oct 15 2018, 10:32 PM
patrickelectric requested changes to this revision.Oct 15 2018, 11:33 PM
patrickelectric added inline comments.
src/core/atcore.cpp
380

You should use the gcode enum.

380

m112 is not compatible in all firmwares.

This revision now requires changes to proceed.Oct 15 2018, 11:33 PM
rizzitello marked 2 inline comments as done.
rizzitello edited the summary of this revision. (Show Details)

Remove unneeded code

rizzitello added inline comments.Oct 16 2018, 12:42 AM
src/core/atcore.cpp
380

Looking more into this i don't even need to do this since in the emergencyStop function the queue is cleared.

use Gcode enum

rizzitello added inline comments.Oct 16 2018, 1:07 AM
src/core/atcore.cpp
380

Adjusted to use GCode enum. Clear only happens when printing.

tcanabrava accepted this revision.Oct 16 2018, 11:32 AM
  • Add missing scoped enum
patrickelectric accepted this revision.Oct 23 2018, 1:37 PM
This revision is now accepted and ready to land.Oct 23 2018, 1:37 PM
rizzitello closed this revision.Oct 23 2018, 7:29 PM