Changed old style casts
Needs ReviewPublic

Authored by carlos_hdc on Oct 10 2018, 9:45 PM.

Details

Reviewers
pino
tcanabrava
Summary

Updated old style casts in some files

Diff Detail

Repository
R326 Kalzium
Branch
casting_changes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3763
Build 3781: arc lint + arc unit
carlos_hdc created this revision.Oct 10 2018, 9:45 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 10 2018, 9:45 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
carlos_hdc requested review of this revision.Oct 10 2018, 9:45 PM
carlos_hdc retitled this revision from Changed old style casts Altered old style casts in some files, refactored some lines to avoid repeated casts and removed lines that would never be executed. to Changed old style casts.Oct 10 2018, 9:51 PM
carlos_hdc edited the summary of this revision. (Show Details)
pino requested changes to this revision.Oct 11 2018, 4:42 AM

please remove the mention of changes different than old style casts in the commit message

libscience/isotope.cpp
97

this change is OK, but please create a separate commit for it

src/calculator/concCalculator.cpp
291

ditto

299

ditto

331

ditto

341

ditto

371–372

ditto

621

ditto

src/spectrumwidget.cpp
219

floor() does not have a "int" variant, so forcing the type of its argument to double helps the compiler to choose the right variant

This revision now requires changes to proceed.Oct 11 2018, 4:42 AM
carlos_hdc updated this revision to Diff 43391.Oct 11 2018, 2:24 PM
carlos_hdc edited the summary of this revision. (Show Details)
carlos_hdc updated this revision to Diff 43395.Oct 11 2018, 2:34 PM
  • Fixed the removed cast

Hi,
Seems like I messed up again in this review (I'm really sorry again). I'm at Lakademy and I asked for help to fix the mess i've made, as soon as the review is fixed I'll let you know.
Sorry again :(
Carlos

carlos_hdc updated this revision to Diff 43417.Oct 11 2018, 7:31 PM

Removed unrelated commits and left only the cast-related lines.