File indexer closing improvements.
AbandonedPublic

Authored by smithjd on Jun 7 2018, 11:54 PM.

Details

Reviewers
bruns
mgallien
poboiko
Group Reviewers
Baloo
Summary

Stop content indexing when the file indexer is asked to close. Halt all indexing when the config changes.

BUG: 353559
FIXED-IN: 5.52

Diff Detail

Repository
R293 Baloo
Branch
master-scheduler-haltonquit (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3755
Build 3773: arc lint + arc unit
smithjd created this revision.Jun 7 2018, 11:54 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 7 2018, 11:54 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
smithjd requested review of this revision.Jun 7 2018, 11:54 PM
bruns added a comment.Jun 19 2018, 1:28 AM

Please provide a more specific commit message, i.e. what is "closing"
The commit message should be understandable *without* reading the code change.

smithjd retitled this revision from Quit the file indexer when closing. to file indexer closing inprovements..Jun 21 2018, 1:02 AM
smithjd edited the summary of this revision. (Show Details)
smithjd updated this revision to Diff 36416.Jun 21 2018, 1:03 AM

Consolidate file indexer close changes into a single review.

smithjd updated this revision to Diff 36702.Jun 26 2018, 5:26 PM

Change git commit description.

smithjd retitled this revision from file indexer closing inprovements. to File indexer closing improvements..Jun 26 2018, 5:29 PM
ngraham edited the summary of this revision. (Show Details)Oct 10 2018, 9:30 PM
bruns requested changes to this revision.Oct 10 2018, 9:55 PM
bruns added inline comments.
src/file/mainhub.cpp
68

Unrelated change

This revision now requires changes to proceed.Oct 10 2018, 9:55 PM

The summary does in no way match the change.

bruns requested changes to this revision.Oct 11 2018, 10:07 PM

The content and summary still do not match.

This revision now requires changes to proceed.Oct 11 2018, 10:07 PM
smithjd abandoned this revision.Jun 17 2019, 1:05 AM