Warning Clean
ClosedPublic

Authored by rizzitello on Sep 30 2018, 3:42 PM.

Diff Detail

Repository
R232 AtCore
Branch
warningClean
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3739
Build 3757: arc lint + arc unit
rizzitello created this revision.Sep 30 2018, 3:42 PM
rizzitello requested review of this revision.Sep 30 2018, 3:42 PM
patrickelectric requested changes to this revision.Sep 30 2018, 3:55 PM
patrickelectric added inline comments.
src/widgets/plotwidget.cpp
89

what are you trying to accomplish here ?

testclient/mainwindow.cpp
157–158

negative numbers will overflow.

This revision now requires changes to proceed.Sep 30 2018, 3:55 PM
rizzitello marked 2 inline comments as done.Oct 1 2018, 12:47 AM
rizzitello added inline comments.
src/widgets/plotwidget.cpp
89

This warning is what I'm trying to remove.

plotwidget.cpp:89: warning: implicit conversion changes signedness: 'const uint' (aka 'const unsigned int') to 'int'

I think I have a better solution here with my next update.

testclient/mainwindow.cpp
157–158

The range here is 1-300. It will not be negative.

rizzitello updated this revision to Diff 42649.Oct 1 2018, 10:07 AM
rizzitello marked 2 inline comments as done.
  • Better way to clear warning
tcanabrava accepted this revision.Oct 7 2018, 10:38 AM
testclient/mainwindow.cpp
157–158

How can you assure that to be future proof ?
You should use std::max

rizzitello updated this revision to Diff 43344.Oct 10 2018, 7:56 PM
  • use std::max
rizzitello updated this revision to Diff 43346.Oct 10 2018, 8:21 PM
  • use std::max correctly
  • Remove added new line
laysrodrigues accepted this revision.Oct 13 2018, 1:37 PM

looks sane to me

patrickelectric accepted this revision.Oct 13 2018, 6:03 PM
This revision is now accepted and ready to land.Oct 13 2018, 6:03 PM
rizzitello closed this revision.Oct 13 2018, 7:05 PM