Differential D15974

Add 'Mount' option to context menu of unmounted device in Places
ClosedPublic
Actions

Authored by thsurrel on Oct 5 2018, 8:49 PM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
VDG
Commits
R318:467df92fb9f2: Add 'Mount' option to context menu of unmounted device in Places
Summary

This is only a proposal but:
1/ it the sysmetric of the Unmount entry in the context menu of mounted devices
2/ I have to admit it took me a very long time to discover (by accident) that you can just (left-)click on a unmounted device to get it mounted automatically. I might not be the only feeling that you should be able to mount a device from the context menu ...

Twin of D15988 in Kio while dolphin is not based on the kio code for Places.

Diff Detail

Repository
R318 Dolphin
Branch
arc_mount
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3550
Build 3568: arc lint + arc unit
thsurrel created this revision.Oct 5 2018, 8:49 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 5 2018, 8:49 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
thsurrel requested review of this revision.Oct 5 2018, 8:49 PM
thsurrel added a comment.Oct 5 2018, 8:50 PM
This comment was removed by thsurrel.
acrouthamel added a subscriber: acrouthamel.EditedOct 5 2018, 8:55 PM

Hey Thomas, just a note that you should put your initial comments and screenshot in the Summary/Details of the diff so it doesn't get lost after lengthy discussion.

thsurrel edited the summary of this revision. (Show Details)Oct 5 2018, 8:57 PM

Point taken, thanks!

acrouthamel added a comment.Oct 5 2018, 9:00 PM

+1 btw from me, makes sense and the context menu isn't very cluttered.

thsurrel updated this revision to Diff 42980.Oct 6 2018, 7:25 PM

Use existing requestStorageSetup method

thsurrel edited the summary of this revision. (Show Details)Oct 6 2018, 7:27 PM
ngraham accepted this revision.Oct 6 2018, 11:29 PM
ngraham added a subscriber: ngraham.

I think this makes sense. Awesome work lately, Thomas.

This revision is now accepted and ready to land.Oct 6 2018, 11:29 PM
elvisangelaccio accepted this revision.Oct 7 2018, 9:13 AM
Closed by commit R318:467df92fb9f2: Add 'Mount' option to context menu of unmounted device in Places (authored by thsurrel). · Explain WhyOct 7 2018, 1:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/panels/places/placespanel.cpp (9 lines)

Diff 42980

View Options

src/panels/places/placespanel.cpp

Loading...