Fix compilation on Windows
ClosedPublic
Actions

Authored by sdepiets on Oct 3 2018, 2:13 AM.

Details

Reviewers

pino
cordlandwehr

Group Reviewers

Artikulate
KDE Edu

Commits

R72:8c38794bb55d: Fix compilation on Windows

Summary

Two issues preventing compilation on windows :

ResourceInterface was missing an export definition
The gstreamer/qtmultimedia backends plugins were using the same export include than libsound

Diff Detail

Repository

R72 Artikulate

Branch

arcpatch-D15914

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3455
Build 3473: arc lint + arc unit

sdepiets created this revision.Oct 3 2018, 2:13 AM

Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 3 2018, 2:13 AM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

Harbormaster completed remote builds in B3446: Diff 42771.Oct 3 2018, 2:13 AM

sdepiets requested review of this revision.Oct 3 2018, 2:13 AM

sdepiets edited the summary of this revision. (Show Details)Oct 3 2018, 2:19 AM

sdepiets added reviewers: Artikulate, KDE Edu.

sdepiets added a project: Windows.

What about dropping all the export stuff from plugins? Nothing links to them, so no symbols are needed outside.

This revision now requires changes to proceed.Oct 3 2018, 5:24 AM

Yes, Pino is right, the export headers for the plugins are artifacts from a refactoring, which is not needed anymore.
It would be great if you could remove the export headers for both of the plugins.

Remove export from libsound/qtplugins

Harbormaster completed remote builds in B3455: Diff 42792.Oct 3 2018, 1:31 PM

cordlandwehr accepted this revision.Oct 3 2018, 5:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2018, 1:04 AM

Closed by commit R72:8c38794bb55d: Fix compilation on Windows (authored by sdepiets). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libsound/src/qtgstreamerbackend/qtgstreamerbackend.h (3 lines)
M			libsound/src/qtgstreamerbackend/qtgstreamerbackend.cpp (1 line)
M			libsound/src/qtmultimediabackend/qtmultimediabackend.h (3 lines)
M			libsound/src/qtmultimediabackend/qtmultimediabackend.cpp (1 line)
M			src/core/resources/resourceinterface.h (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	42771	2e3d80f		Oct 3 2018, 2:13 AM	★	★
Diff 2	42792	2e3d80f	Remove export from libsound/qtplugins	Oct 3 2018, 1:31 PM	★	★
Diff 3	42827	2e3d80f	R72:8c38794bb55d9c620f61768f78105c1f79a4c983	Oct 4 2018, 1:03 AM	★	★