option to specify icons spacing for systray
Needs ReviewPublic
Actions

Authored by mvourlakos on Sep 30 2018, 5:18 PM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Summary

--added a new configuration option in order for
users to alter the systray icons spacing in pixels.
The option can be specified through new Appearance
configuration page of the systray applet.

Test Plan

-check different spacing values in order to confirm
behavior
-check both for one-line or multi-lines systray
layouts

Diff Detail

Repository

R120 Plasma Workspace

Branch

systraySpacing

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3371
Build 3389: arc lint + arc unit

mvourlakos created this revision.Sep 30 2018, 5:18 PM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 30 2018, 5:18 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mvourlakos requested review of this revision.Sep 30 2018, 5:19 PM

Harbormaster completed remote builds in B3371: Diff 42614.Sep 30 2018, 5:19 PM

[new option for icons spacing]

[systray demonstrating 10px. icons spacing]

Zren added a subscriber: Zren.Sep 30 2018, 6:05 PM

Zren added inline comments.

applets/systemtray/package/contents/ui/main.qml
310	Hmm. We might want to scale by DPI. While the default 0px will not be affected by DPI, if a Look And Feel sets it to 10px, it would look different for users with 1x DPI and 2x DPI. Eg: spacing: plasmoid.configuration.iconsSpacing * units.devicePixelRatio

Zren added inline comments.Sep 30 2018, 6:07 PM

applets/systemtray/package/contents/ui/main.qml
310	We probably need to round it too so that the icons start on integer coordinates. spacing: Math.round(plasmoid.configuration.iconsSpacing * units.devicePixelRatio)

I'm really against this type of micro-options

mart added a reviewer: VDG.Nov 23 2018, 2:17 PM

FWIW I agree with @mart. Just give it a default value and leave it at that. More configuration doesn't necessarily mean better.

Revision Contents
Changeset List

		Path
M		applets/systemtray/package/contents/config/config.qml (5 lines)
M		applets/systemtray/package/contents/config/main.xml (5 lines)
A	M	applets/systemtray/package/contents/ui/ConfigAppearance.qml (52 lines)
M		applets/systemtray/package/contents/ui/main.qml (2 lines)