Differential D15823

[Folder View] In list view mode, fix home button disappearing every other subfolder entered
ClosedPublic
Actions

Authored by thsurrel on Sep 28 2018, 8:59 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
VDG
Commits
R119:df458e9ea505: [Folder View] In list view mode, fix home button disappearing every other…
Test Plan

Add a Folder View in a panel, open it in "list view" mode.
Navigate through several subfolders: the 'home' button that appears in the top left corner of the applet should not disappear every even number of subfolder you open.

Diff Detail

Repository
R119 Plasma Desktop
Branch
arc_folderview (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3314
Build 3332: arc lint + arc unit
thsurrel created this revision.Sep 28 2018, 8:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 28 2018, 8:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
thsurrel requested review of this revision.Sep 28 2018, 8:59 PM
thsurrel updated this revision to Diff 42526.Sep 28 2018, 9:02 PM
This comment was removed by thsurrel.
thsurrel updated this revision to Diff 42527.Sep 28 2018, 9:09 PM

Sorry, this second commit ended up in the same arc diff, this is not what I intended.
I'm still learning...

thsurrel edited the test plan for this revision. (Show Details)Oct 1 2018, 3:00 PM
hein accepted this revision.Oct 2 2018, 8:43 AM
hein added a subscriber: hein.

Nice catch!

This revision is now accepted and ready to land.Oct 2 2018, 8:43 AM
thsurrel added a comment.Oct 2 2018, 12:19 PM

I don't have a developer account, can you be the pilot for landing this ? Thanks in advance.

abetts added a subscriber: abetts.Oct 2 2018, 1:41 PM

Screenshot?

thsurrel added a comment.Oct 2 2018, 1:50 PM


Showing the missing home button in the top left corner. The button would appear again if I would navigate one folder up or down.

abetts added a comment.Oct 2 2018, 1:54 PM
In D15823#335296, @thsurrel wrote:


Showing the missing home button in the top left corner. The button would appear again if I would navigate one folder up or down.

Thank you

Closed by commit R119:df458e9ea505: [Folder View] In list view mode, fix home button disappearing every other… (authored by thsurrel). · Explain WhyOct 5 2018, 9:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42527

View Options

containments/desktop/package/contents/ui/FolderViewLayer.qml

Loading...