More Cleanup
ClosedPublic

Authored by rizzitello on Sep 23 2018, 1:02 AM.

Diff Detail

Repository
R232 AtCore
Branch
moreCleanup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3138
Build 3156: arc lint + arc unit
rizzitello requested review of this revision.Sep 23 2018, 1:02 AM
rizzitello created this revision.
rizzitello set the repository for this revision to R232 AtCore.
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
patrickelectric requested changes to this revision.Sep 23 2018, 1:09 AM
patrickelectric added inline comments.
src/core/printthread.cpp
141

Such precision is not necessary.

211

So -1 will be 2ˆ32 -1, tests need to be done before settings extruder temperature.

This revision now requires changes to proceed.Sep 23 2018, 1:09 AM
rizzitello updated this revision to Diff 42158.Sep 23 2018, 1:31 AM
rizzitello marked an inline comment as done.
  • patrick Suggestions
rizzitello updated this revision to Diff 42160.Sep 23 2018, 1:54 AM
  • Clean warning for job progress
rizzitello updated this revision to Diff 42161.Sep 23 2018, 2:57 AM
  • Add basic range check to prevent overflow of uints
rizzitello updated this revision to Diff 42163.Sep 23 2018, 3:06 AM
  • Clear the extruder list before updating
  • Clear fan selector before updating
tcanabrava added inline comments.Sep 23 2018, 5:12 PM
src/core/atcore.cpp
617–619

speed = std::max(speed, 255);

The same applies for all of the other comparissons that you are doing in this review.

rizzitello updated this revision to Diff 42198.Sep 23 2018, 6:59 PM
  • Tomaz's std::min suggetion
rizzitello marked 2 inline comments as done.Sep 23 2018, 7:01 PM
patrickelectric accepted this revision.Sep 25 2018, 1:42 PM
This revision is now accepted and ready to land.Sep 25 2018, 1:42 PM
tcanabrava accepted this revision.Sep 25 2018, 2:32 PM
rizzitello closed this revision.Sep 25 2018, 8:54 PM