Frame/Textarea/Jump swap seems broken because I build up those repeaters from the count of those values, but if the count stays the same, the repeater has no need to change, so they effectively don't update.

So I tried using QQmlListProperty again, for frames, and while this builds:

in page.cpp

QQmlListProperty<Frame> Page::frameList()
{
    return QQmlListProperty<Frame>(this, nullptr, &Page::frameCount, &Page::frameAt);
}

Frame * Page::frame(int index) const
{
    return d->frames.at(index);
}

Frame *Page::frameAt(QQmlListProperty<Frame> *list, int index)
{
    Page* page = qobject_cast<Page*>(list->object);
    if (page) {
        return page->frames().at(index);
    }
    return nullptr;
}

int Page::frameCount(QQmlListProperty<Frame> *list)
{
    Page* page = qobject_cast<Page*>(list->object);
    if (page) {
        return page->frames().size();
    }
    return 0;
}

and page.h

 Q_PROPERTY(QQmlListProperty<Frame> frameList READ frameList NOTIFY frameCountChanged)
 
 [...]

 QQmlListProperty<Frame> frameList();

 static Frame* frameAt(QQmlListProperty<Frame> *list, int index);
 static int frameCount(QQmlListProperty<Frame> *list);

Q_SIGNAL void frameCountChanged();

It also needs a property registery? But I can't for the life of me figure out how to set that up, when I copy qmlplugin to the acbf folder it complains it cannot find the qmlengine type despite including QtQml/QQmlEngine. I am giving up on this now.

Will try to continue with the other items.

In D15542#327446, @woltherav wrote:

It also needs a property registery? But I can't for the life of me figure out how to set that up, when I copy qmlplugin to the acbf folder it complains it cannot find the qmlengine type despite including QtQml/QQmlEngine. I am giving up on this now.

Ah, yes, quite... i never really intended libacbf to be a QML plugin, it was supposed to be a generic Qt library for handling ACBF files... But, i guess there's nothing really to stop us turning it into one such, it /would/ make life easier in some ways. I imagine the reason it's breaking (or certainly part of it) is that libacbf is only linked against Qt5::Core, but to create a QML plugin you also need to link against Qt5::Qml. It would, perhaps, also make packaging a little easier in some ways. It does mean changing the cmakelists.txt for libacbf to produce a QML plugin rather than a normal library. The problem with doing that is that the peruse plugin is linked against libacbf, which you can't do with a qml plugin. Hm, it... looks like there might be a chicken/egg issue developing here... There is the option that emitting the signal for count changing twice would work, one for removing the two items being swapped, and one once they've been reinserted in their new locations? It's a little ugly, perhaps, but i'm thinking it would probably work...

Okay, updated with the changed you suggested. (And all my own changes I thought were really necessary.)

I am not sure whether to pursue the page area swapping now. I've hidden the actions for now as it is a bit too difficult for me to make sensible decisions here.

I actually did manage to get the swap working just now, I replaced the counts with stringlists with the points of the frames(which should be useful for debug as well :) )

I'll go merge in a bit!

In D15542#327982, @woltherav wrote:

I actually did manage to get the swap working just now, I replaced the counts with stringlists with the points of the frames(which should be useful for debug as well :) )

That sounds... interesting ;) i look forward to seeing how you're doing that :D

I'll go merge in a bit!

Great! :)