[TerminalDisplay] Handle forward/backward buttons to switch tabs
ClosedPublic

Authored by anthonyfieroni on Jul 31 2018, 2:30 PM.

Details

Summary

Clicking mouse forward/backward buttons switch tabs

Test Plan

Tested

Diff Detail

Repository
R319 Konsole
Lint
Lint Skipped
Unit
Unit Tests Skipped
anthonyfieroni created this revision.Jul 31 2018, 2:30 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 31 2018, 2:30 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Jul 31 2018, 2:30 PM

Fix copy-pasta bug

Just to clarify, this is for a mouse which have extra button on side correct? I actually don't think I own such a mouse.

Just to clarify, this is for a mouse which have extra button on side correct?

Yes, you should try it, the buttons are helpful and makes you lazy :)

ngraham added a subscriber: ngraham.Aug 3 2018, 2:15 PM

Dang, I wish I still had one of those mice so I could help test.

Any chance you'd be willing to submit a similar patch to Gwenview so that you can use the mouse's back and forward buttons to navigate between images while in View mode?

Any chance you'd be willing to submit a similar patch to Gwenview so that you can use the mouse's back and forward buttons to navigate between images while in View mode?

Yes it looks like useful i'll provide a patch.

The concern I have about this is someone is going to wait to disable this, change the actions, etc. It is too bad this can't be done in the shortcut dialog/interface.

anthonyfieroni added a comment.EditedAug 14 2018, 1:07 PM

It can be added an option in profile -> mouse but why someone want to disable it, he/she can predefine mouse buttons, or not use them at all, i don't know other option :)

Do we have to add an option right now from the get-go? I have a hard time imagining that anyone will complain, since (and correct me if I'm wrong) the side buttons currently do nothing in Konsole. Can we wait to add an option until we get a Bugzilla tickets with complaints?

Ping, any objections?

tcanabrava requested changes to this revision.Sep 17 2018, 12:56 PM
tcanabrava added a subscriber: tcanabrava.
tcanabrava added inline comments.
src/MainWindow.cpp
925

return KXmlGuiWindow::eventFilter ?

933–938

extract those to a function so you don't repeat yourself?
case Qt::ForwardButton: triggerAction("next-view");
case Qt::BackButton: triggerAction("previus-view");

?

This revision now requires changes to proceed.Sep 17 2018, 12:56 PM
anthonyfieroni marked 2 inline comments as done.
tcanabrava accepted this revision.Sep 17 2018, 1:23 PM
This revision is now accepted and ready to land.Sep 17 2018, 1:23 PM
This revision was automatically updated to reflect the committed changes.