[effects/showpaint] Modernize code
ClosedPublic

Authored by zzag on Sep 11 2018, 1:00 PM.

Details

Summary

Summary of changes:

  • Use QVector to store colors
  • Add Q_OBJECT macro
  • Port away from QRegion::rects
  • Fix coding style
  • Use default member initialization
  • Use nullptr
  • Reserve rects in paintXrender

The behavior of this effect haven't been changed, it still acts as before.

Test Plan

Compiles, and the Show Paint effect is still a psychedelic thing.

Diff Detail

Repository
R108 KWin
Branch
effects-showpaint-modernize
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2720
Build 2738: arc lint + arc unit
zzag created this revision.Sep 11 2018, 1:00 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 11 2018, 1:00 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 11 2018, 1:00 PM
zzag updated this revision to Diff 41403.Sep 11 2018, 1:06 PM

Constify alpha in paintXrender

zzag updated this revision to Diff 41404.Sep 11 2018, 1:10 PM

Add alpha const

davidedmundson accepted this revision.Sep 11 2018, 1:18 PM
This revision is now accepted and ready to land.Sep 11 2018, 1:18 PM
This revision was automatically updated to reflect the committed changes.