Differential D15373

[effects] Fix type of X-KWin-Video-Url
ClosedPublic
Actions

Authored by zzag on Sep 9 2018, 11:26 AM.

Details

Reviewers
broulik
Group Reviewers
KWin
Commits
R108:113ebe9bc225: [effects] Fix type of X-KWin-Video-Url
Summary

The desktop file parser supports only QString, QStringList, Int, Double,
and Bool. QUrl is not a supported type for some reason.

Thus, let's use QString for X-KWin-Video-Url.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sep 9 2018, 11:26 AM
Restricted Application added a project: KWin. · View Herald TranscriptSep 9 2018, 11:26 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 9 2018, 11:26 AM
Zren added a subscriber: Zren.Sep 9 2018, 5:10 PM

I noticed this in https://phabricator.kde.org/D12249#247452, but didn't realize that it was missing the code for loading the effects in the KCM like D15372 adds. Nice work on D15372!

broulik accepted this revision.Sep 9 2018, 7:32 PM
This revision is now accepted and ready to land.Sep 9 2018, 7:32 PM
Closed by commit R108:113ebe9bc225: [effects] Fix type of X-KWin-Video-Url (authored by zzag). · Explain WhySep 11 2018, 11:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/kwineffect.desktop (2 lines)

Diff 41391

View Options

effects/kwineffect.desktop

Loading...