improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch
ClosedPublic
Actions

Authored by cullmann on Aug 28 2018, 4:54 PM.

Details

Reviewers

vkrause
dhaumann

Commits

R216:9556855dcf18: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch

Test Plan

make && make test

before, perf tells for

perf record -g ./bin/htmlhighlighter_test

> Rule::match 40% & KeywordListRule::doMatch 26%

after the patch

> Rule::match 17% & KeywordListRule::doMatch 4.5%

binary search was slower, contains is much faster on the VERY small strings

Diff Detail

Repository

R216 Syntax Highlighting

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2310
Build 2328: arc lint + arc unit

cullmann created this revision.Aug 28 2018, 4:54 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 28 2018, 4:54 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

cullmann requested review of this revision.Aug 28 2018, 4:54 PM

Harbormaster completed remote builds in B2308: Diff 40571.Aug 28 2018, 4:54 PM

And yes, you see even the costs for the auto defData = DefinitionData::get(m_def.definition()); as a high percentage, close to the total costs of KeywordListRule::doMatch now.

optimize html exporter, 23% => 15% of runtime for applyFormat in unit test

Harbormaster completed remote builds in B2309: Diff 40572.Aug 28 2018, 5:05 PM

add my copyright, too

Harbormaster completed remote builds in B2310: Diff 40573.Aug 28 2018, 5:13 PM

Very nice, thank you!

This revision is now accepted and ready to land.Aug 28 2018, 5:32 PM

Closed by commit R216:9556855dcf18: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch (authored by cullmann). · Explain WhyAug 28 2018, 8:26 PM

This revision was automatically updated to reflect the committed changes.

Very nice.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/htmlhighlighter.cpp (37 lines)
M			src/lib/rule.cpp (12 lines)
M			src/lib/rule_p.h (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40571	1844834		Aug 28 2018, 4:54 PM	★	★
Diff 2	40572	1844834	optimize html exporter, 23% => 15% of runtime for applyFormat in unit test	Aug 28 2018, 5:05 PM	★	★
Diff 3	40573	1844834	add my copyright, too	Aug 28 2018, 5:13 PM	★	★
Diff 4	40579	1844834	R216:9556855dcf1882f8c34b7008a0ee90e55a56fa54	Aug 28 2018, 8:25 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2c3a8742d4d6	94bfff1abfdb	184483443f4f	Christoph Cullmann	improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch (Show More…)	Aug 28 2018, 4:54 PM