Details
- Reviewers
TheAssassin anthonyfieroni - Group Reviewers
Plasma VDG - Commits
- R320:e88a4c3d4a02: Add AppImage thumbnailer
Diff Detail
- Repository
- R320 KIO Extras
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
thumbnail/CMakeLists.txt | ||
---|---|---|
267 | It should be conditional, see htmlthumbnail or audiothumbnail |
thumbnail/CMakeLists.txt | ||
---|---|---|
267 | Yeah I noticed that just before you commented :) |
Looks good to me. I'm not a KDE expert and can't tell much about that, but the AppImage part is perfectly fine. At some point, the temporary file should be replaced by some in-memory file buffer. See https://github.com/AppImage/libappimage/issues/1 for reference.
Does this need to be turned on somehow, or should it Just Work?
Also, your screenshot really brings home how much we need to have the ability to turn off that shadowed border for certain things:
https://bugs.kde.org/show_bug.cgi?id=258514
https://bugs.kde.org/show_bug.cgi?id=378701
See also a seemingly failed over-broad attempt to do that for Dolphin: D5420
Also, your screenshot really brings home how much we need to have the ability to turn off that shadowed border for certain things:
Well, ThumbCreator has a flags() for DrawFrame that got deprecated for whatever reason. Currently Dolphin paints a frame around all thumbnails except for Windows EXE files (so they look more like regular files)
is this exclusive to thumbnails? I am curious if this file detection could be used for offering a dialog to give execution permissions rather than the "open with" dialog.
@michaeltunnell that's a great idea to generally improve the UX with AppImages or, even better, all ELF files. Then, one of the issues https://github.com/TheAssassin/AppImageLauncher tries to solve is already solved upstream, at least for KDE.
Can it be included/installed in KDE neon?
Installed sudo apt install kio-extras (4:18.08.3+p18.04+git20181130.0153-0).