Add AppImage thumbnailer
ClosedPublic

Authored by broulik on Aug 22 2018, 11:49 AM.

Details

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik requested review of this revision.Aug 22 2018, 11:49 AM
broulik created this revision.
broulik updated this revision to Diff 40218.Aug 22 2018, 12:05 PM
  • Install .desktop file only when built
anthonyfieroni added inline comments.
thumbnail/CMakeLists.txt
267

It should be conditional, see htmlthumbnail or audiothumbnail

broulik added inline comments.Aug 22 2018, 12:08 PM
thumbnail/CMakeLists.txt
267

Yeah I noticed that just before you commented :)

anthonyfieroni accepted this revision.Aug 22 2018, 12:10 PM
This revision is now accepted and ready to land.Aug 22 2018, 12:10 PM

Looks good to me. I'm not a KDE expert and can't tell much about that, but the AppImage part is perfectly fine. At some point, the temporary file should be replaced by some in-memory file buffer. See https://github.com/AppImage/libappimage/issues/1 for reference.

This revision was automatically updated to reflect the committed changes.
abetts added a subscriber: abetts.Aug 22 2018, 3:23 PM

Does this patch set the thumbnail size?

Does this need to be turned on somehow, or should it Just Work?

Also, your screenshot really brings home how much we need to have the ability to turn off that shadowed border for certain things:

https://bugs.kde.org/show_bug.cgi?id=258514
https://bugs.kde.org/show_bug.cgi?id=378701

See also a seemingly failed over-broad attempt to do that for Dolphin: D5420

Also, your screenshot really brings home how much we need to have the ability to turn off that shadowed border for certain things:

Well, ThumbCreator has a flags() for DrawFrame that got deprecated for whatever reason. Currently Dolphin paints a frame around all thumbnails except for Windows EXE files (so they look more like regular files)

is this exclusive to thumbnails? I am curious if this file detection could be used for offering a dialog to give execution permissions rather than the "open with" dialog.

@michaeltunnell that's a great idea to generally improve the UX with AppImages or, even better, all ELF files. Then, one of the issues https://github.com/TheAssassin/AppImageLauncher tries to solve is already solved upstream, at least for KDE.

probono added a subscriber: probono.EditedDec 6 2018, 6:51 PM

Can it be included/installed in KDE neon?

Installed sudo apt install kio-extras (4:18.08.3+p18.04+git20181130.0153-0).

Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptDec 6 2018, 6:51 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript

Can it be included/installed in KDE neon?

You should ask on Neon request channels.