The return code of the Pool::load() method is somewhat misleading, as it
returns true only if there were no errors at all. The error flag is set on the first
validation error, but the pool will contain meaningful data nevertheless.
BUG: 397531
apol |
Plasma | |
Frameworks |
The return code of the Pool::load() method is somewhat misleading, as it
returns true only if there were no errors at all. The error flag is set on the first
validation error, but the pool will contain meaningful data nevertheless.
BUG: 397531
Searching for "blend"
Unfixed version:
No results are returned under "Software Center"
Fixed version:
Software Center: "Get Blender", "Get Hugin", ...
No Linters Available |
No Unit Test Coverage |
Buildable 2083 | |
Build 2101: arc lint + arc unit |
This is outright weird, please send just one patch with the feature and the logging and without the wrong lines.
Which wrong lines?
Why should I squash the commits? Each one:
Citing from https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets
OTOH, commits should be preferably "atomic" - not splittable. That means that every bugfix, feature, refactoring or reformatting should go into an own commit. This, too, improves the readability of the history.
Ugh, like I said, can you please squash them into a commit?
They are good changes in general.
As I said, that violates https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets and I prefer to keep these apart.
This one fixes the behaviour, and has a separate bug report.
The other ones change logging and are quite independent.