Move the icons from D10937 to plasma-frameworks and combine all the sizes
BUG: 395714
ngraham | |
broulik |
VDG |
Move the icons from D10937 to plasma-frameworks and combine all the sizes
BUG: 395714
"osd-shutd-screen.svg" does not display correctly for me. I can't find any difference between it and the rest of the icons. Help appreciated.
No Linters Available |
No Unit Test Coverage |
Buildable 2080 | |
Build 2098: arc lint + arc unit |
If we rename the icons, we will need to correspondingly change the OSD code itself to use the new names: https://cgit.kde.org/kscreen.git/tree/kded/qml/OsdSelector.qml#n51
Unfortunately, that code lives in KScreen, which uses the Plasma release schedule rather than the Frameworks schedule. Therefore we cannot guarantee that people will be using the right combination of the two pieces of code; it's perfectly possible for a distro to ship KDE Frameworks 5.50 (with the renamed files) but KDE Plasma 5.13.5 (which would use the old names). If these lived on-disk, I'd suggest just making a symlink. Can we do that here internally? Is there any way to give one image two names in the svgz file?
Either way, that should be done in a separate commit. Please revert the name change and we'll do that later. It's important to keep patches as small as possible to keep the git history clean, and also make it easy to revert any individual change that caused problems.
File looking good, not really a fan of the new thin lined icon style, but the file must be named osd.svgz (Plasma always uses the part before the first hyphen for lookup)
When I apply this patch and compile and deploy plasma-framework to /usr/ and then delete the Breeze icons versions, I still don't see the new icons in the switcher. What am I doing wrong?
Did you nuke the plasma icon cache? ~/.cache/plasma* (We need to bump the theme version number before frameworks tagging, then this will work automatically)
Nah, I'll land this now, and bump X-KDE-PluginInfo-Version in src/desktoptheme/breeze/metadata.desktop before Frameworks 5.51 tagging.
Thanks so much for your work here, Phil! I know it's been a long road, but I'm going to land this now.
For your next patch, for all the icons that currently have a desktop-looking screen, could you make additional versions that have a laptop instead? Then we can patch KScreen for Plasma 5.15 to dynamically show one set or other other depending on whether you're on a laptop or a desktop. That'll be totally awesome.