This Patch brings the following fixes:
- Now It shows proper release data.
- Now showing proper size.
- added a default icon for updates (device-notifier)
- fixes some end-case
apol | |
davidedmundson |
This Patch brings the following fixes:
Lint Skipped |
Unit Tests Skipped |
Reviewing the patch with such menial styling changes becomes to hard, please clean up first.
The spaces change is indeed correct, maybe just commit that part first, for easier review.
libdiscover/backends/FwupdBackend/FwupdBackend.h | ||
---|---|---|
84 | Why did you change all device to dev? |
sure
libdiscover/backends/FwupdBackend/FwupdBackend.h | ||
---|---|---|
84 | I was using "rel" for releases, so for uniformity, I changed the devices to "dev". |
libdiscover/backends/FwupdBackend/FwupdBackend.h | ||
---|---|---|
84 | Not a big fan, please revert. If anything change rel to release. |
libdiscover/backends/FwupdBackend/FwupdBackend.h | ||
---|---|---|
84 | How about instead using "releases" for "releases?" :) Short variable names are a false economy. |
libdiscover/backends/FwupdBackend/FwupdBackend.h | ||
---|---|---|
84 | okay sure! |
This diff only contains the changes and fixes related to the size of releases show. All the changes related to space and name are committed directly!