There is no need for this, the only use of the engine is when creating QQMLOutputComponent.
Details
Details
- Reviewers
romangg - Group Reviewers
Plasma - Commits
- R104:a6929de88b89: QMLScreen: do not declare the engine a member
Diff Detail
Diff Detail
- Repository
- R104 KScreen
- Branch
- arcpatch-D14476
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1405 Build 1423: arc lint + arc unit
Comment Actions
Note, that m_engine is set in widget.cpp. But it's just a Cpp call to setEngine, which is defined extra. So removing the property macro should be fine.
kcm/src/declarative/qmlscreen.h | ||
---|---|---|
107–108 | This entire custom engine handling could be removed, with QMLScreen using qmlEngine(this) when creating an QMLOutput |
kcm/src/declarative/qmlscreen.h | ||
---|---|---|
107–108 | I had briefly tried and got a nullptr from qmlEngine, but I didn't really spend time on it. |