In D14443#299656, @markg wrote:
+1

It's good to have that!
Also note that you "can" do that in a one-liner with C++14 with a little known library feature.
delete std::exchange(object, nullptr);
But it might be too new and unknown to use throughout the code... I leave it up to you to decide.

Thanks for your advice I appreciate it and I will keep it in mind for the future, but let's keep it "old".

Just out of curiosity, what is the motivation for this change? What do we gain by assigning pointers to nullptr? Would it instead make sense to use a smart pointer? Maybe unique_ptr or a Qt version?

broulik added a subscriber: broulik.Jul 30 2018, 8:34 AM

broulik added inline comments.

src/kitemviews/kitemlistview.cpp
308	You're re-assigning it to something else immediately after
323	Same
2744	Unrelated whitespace change

Update

Harbormaster completed remote builds in B1359: Diff 38760.Jul 30 2018, 9:55 AM

Fix Typo

Harbormaster completed remote builds in B1361: Diff 38763.Jul 30 2018, 11:00 AM

In D14443#299704, @hallas wrote:

Just out of curiosity, what is the motivation for this change? What do we gain by assigning pointers to nullptr? Would it instead make sense to use a smart pointer? Maybe unique_ptr or a Qt version?

Yes, porting to smart pointers (wherever possible) would be the best. But setting deleted pointers to null is a common practice because it will help to find some kind of bugs (even though it will hide a double delete, which isn't that good).

src/kitemviews/kitemlistview.cpp
309	Not needed, `widgetCreator` is a local variable that's going out of scope.
324	Same here.
2712	Same here.
src/kitemviews/kstandarditemmodel.cpp
68	Same here, but ok. This one could make sense in case one day someone removes the return.
238	Unrelated whitespace change
src/kitemviews/private/kitemlistviewanimation.cpp
189	Same here, not needed.
236	Unrelated whitespace change
src/panels/folders/folderspanel.cpp
65	Not needed.
369	Unrelated whitespace change
src/panels/places/placespanel.cpp
484	Not needed.
src/tests/kfileitemmodeltest.cpp
1645	Not needed.
src/views/dolphinview.cpp
999	Not needed.
src/views/dolphinviewactionhandler.cpp
581	Not needed.
src/views/tooltips/tooltipmanager.cpp
86	Not needed, we are already assigning it one line below.
212	Unrelated whitespace change

This revision now requires changes to proceed.Jul 31 2018, 9:12 PM

			Path	Packages
M			src/kitemviews/kitemlistview.h (1 line)
M			src/kitemviews/kitemlistview.cpp (4 lines)
M			src/kitemviews/kstandarditemmodel.cpp (3 lines)
M			src/kitemviews/private/kdirectorycontentscounter.cpp (1 line)
M			src/kitemviews/private/kitemlistviewanimation.cpp (2 lines)
M			src/panels/folders/folderspanel.cpp (2 lines)
M			src/panels/places/placesitem.cpp (5 lines)
M			src/panels/places/placespanel.cpp (2 lines)
M			src/tests/dolphinsearchboxtest.cpp (1 line)
M			src/tests/kfileitemmodeltest.cpp (1 line)
M			src/tests/placesitemmodeltest.cpp (4 lines)
M			src/trash/dolphintrash.cpp (2 lines)
M			src/views/dolphinview.cpp (1 line)
M			src/views/dolphinviewactionhandler.cpp (1 line)
M			src/views/tooltips/tooltipmanager.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38661	438f599		Jul 28 2018, 4:04 PM	★	★
Diff 2	38663	438f599	"Fix" Typo	Jul 28 2018, 4:07 PM	★	★
Diff 3	38664	438f599	"Fix" Typo	Jul 28 2018, 4:09 PM	★	★
Diff 4	38760	438f599	Update	Jul 30 2018, 9:55 AM	★	★
Diff 5	38763	438f599	Fix Typo	Jul 30 2018, 11:00 AM	★	★

Use nullptr
Needs RevisionPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 38760

src/kitemviews/kitemlistview.h

src/kitemviews/kitemlistview.cpp

src/kitemviews/kstandarditemmodel.cpp

src/kitemviews/private/kdirectorycontentscounter.cpp

src/kitemviews/private/kitemlistviewanimation.cpp

src/panels/folders/folderspanel.cpp

src/panels/places/placesitem.cpp

src/panels/places/placespanel.cpp

src/tests/dolphinsearchboxtest.cpp

src/tests/kfileitemmodeltest.cpp

src/tests/placesitemmodeltest.cpp

src/trash/dolphintrash.cpp

src/views/dolphinview.cpp

src/views/dolphinviewactionhandler.cpp

src/views/tooltips/tooltipmanager.cpp

Use nullptrNeeds RevisionPublicActions