Differential D14428

Define ownership of edid in output and do not leak it
ClosedPublic
Actions

Authored by gladhorn on Jul 27 2018, 1:41 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R110:e6b197b47b8a: Define ownership of edid in output and do not leak it
Summary

Valgrind showed that in some cases we were leaking the edid in tests.

Test Plan

valgrind --leak-check=full bin/testkwaylandbackend

Diff Detail

Repository
R110 KScreen Library
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1268
Build 1282: arc lint + arc unit
gladhorn created this revision.Jul 27 2018, 1:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 27 2018, 1:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 27 2018, 1:41 PM
gladhorn updated this revision to Diff 38599.Jul 27 2018, 1:42 PM

Add note about the edid pointer becoming invalid

gladhorn updated this revision to Diff 38600.Jul 27 2018, 1:45 PM

Messed up merge :(

gladhorn added a comment.Jul 28 2018, 6:36 AM

The alternative would be to deprecate this and add a new function. I think this is nonetheless sensible.

mart accepted this revision.Nov 23 2018, 2:53 PM
This revision is now accepted and ready to land.Nov 23 2018, 2:53 PM
Closed by commit R110:e6b197b47b8a: Define ownership of edid in output and do not leak it (authored by gladhorn). · Explain WhyNov 25 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/output.h (7 lines)
Msrc/output.cpp (10 lines)

Diff 38599

View Options

src/output.h

Loading...
View Options

src/output.cpp

Loading...